feat(codegen): print leading pragma comments#5789
Closed
Boshen wants to merge 9 commits intographite-base/5789from
Closed
feat(codegen): print leading pragma comments#5789Boshen wants to merge 9 commits intographite-base/5789from
Boshen wants to merge 9 commits intographite-base/5789from
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #5789 will degrade performances by 23.24%Comparing Summary
Benchmarks breakdown
|
Boshen
force-pushed
the
09-15-feat_codegen_print_leading_pragma_comments
branch
from
52691f6 to
2b12726
Compare
Boshen
force-pushed
the
09-15-feat_parser_calculate_leading_or_trailing_position_for_comments
branch
2 times, most recently
from
c936ece to
8e10ffc
Compare
Boshen
force-pushed
the
09-15-feat_codegen_print_leading_pragma_comments
branch
3 times, most recently
from
97d01d2 to
0b47ddf
Compare
Boshen
force-pushed
the
09-15-feat_parser_calculate_leading_or_trailing_position_for_comments
branch
2 times, most recently
from
49d10f3 to
df0ef98
Compare
Boshen
changed the base branch from
09-15-feat_parser_calculate_leading_or_trailing_position_for_comments
to
graphite-base/5789
- Part of #1022 This implements the [recommended rule `no-danger-with-children`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-danger-with-children.md) from the `eslint-plugin-react` package. This rule proved to be a little bit trickier to implement than I anticipated, as it required searching up through all of the scopes recursively in order to resolve object properties. This would be easier with something like a type-check system, but this will work for now. (Sidenote: this is my first real attempt at Rust programming in ~5 years, so any feedback on making this more idiomatic is welcome.)
Boshen
force-pushed
the
09-15-feat_codegen_print_leading_pragma_comments
branch
from
0b47ddf to
c79d011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.