Skip to content

Comments

refactor(linter): shorten Option syntax#5735

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-12-refactor_linter_shorten_option_syntax
Sep 12, 2024
Merged

refactor(linter): shorten Option syntax#5735
graphite-app[bot] merged 1 commit intomainfrom
09-12-refactor_linter_shorten_option_syntax

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 12, 2024

Use Some instead of Option::Some.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-linter Area - Linter label Sep 12, 2024
@overlookmotel overlookmotel marked this pull request as ready for review September 12, 2024 18:33
@overlookmotel
Copy link
Member Author

Uncontroversial change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 12, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 12, 2024

Merge activity

  • Sep 12, 2:38 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 12, 2:39 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 12, 2:48 PM EDT: overlookmotel merged this pull request with the Graphite merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 12, 2024

CodSpeed Performance Report

Merging #5735 will not alter performance

Comparing 09-12-refactor_linter_shorten_option_syntax (20a7861) with main (805fbac)

Summary

✅ 29 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Use `Some` instead of `Option::Some`.
@overlookmotel overlookmotel force-pushed the 09-12-refactor_linter_shorten_option_syntax branch from c08a0e7 to 20a7861 Compare September 12, 2024 18:42
@graphite-app graphite-app bot merged commit 20a7861 into main Sep 12, 2024
@graphite-app graphite-app bot deleted the 09-12-refactor_linter_shorten_option_syntax branch September 12, 2024 18:48
@oxc-bot oxc-bot mentioned this pull request Sep 18, 2024
Boshen added a commit that referenced this pull request Sep 18, 2024
## [0.9.6] - 2024-09-18

### Features

- 3bf7b24 linter: Make `typescript/no-duplicate-enum-values` a
`correctness` rule (#5810) (DonIsaac)
- 7799c06 linter/react: Implement `no-danger-with-children` rule (#5420)
(Cam McHenry)

### Bug Fixes

- f942485 linter: Remove all* remaining "Disallow <foo>" messages
(#5812) (DonIsaac)
- b5ad518 linter: Improve diagnostic messages for various lint rules
(#5808) (DonIsaac)
- 858f7af linter: Plugin prefix name for eslint-plugin-node (#5807)
(DonIsaac)
- 737ba1d linter: Fix some cases on ```AssignmentExpression``` for
```unicorn/consistent-function-scoping``` (#5675) (Arian94)
- 148c7a8 linter: Replace bitwise AND (&) with logical AND (&&) in
explici… (#5780) (kaykdm)
- b4ed564 linter/no-unused-vars: Writes to members triggering false
positive (#5744) (Dunqing)
- e9c084a linter/no-unused-vars: False positive when a variable used as
a computed member property (#5722) (Dunqing)

### Performance

- 3725d5d linter: Make all rules share a diagnostics vec (#5806)
(DonIsaac)
- e978567 linter: Shrink size of `DisableDirectives` (#5798) (DonIsaac)
- 1bfa515 linter: Remove redundant clone of diagnostics in context
(#5797) (DonIsaac)
- e413cad linter: Move shared context info to `ContextHost` (#5795)
(DonIsaac)

### Refactor

- 6dd6f7c ast: Change `Comment` struct (#5783) (Boshen)
- 7caae5b codegen: Add `GetSpan` requirement to `Gen` trait (#5772)
(Boshen)
- 026ee6a linter: Decouple module resolution from import plugin (#5829)
(dalaoshu)
- 50834bc linter: Move `override_rule` to `OxlintRules` (#5708)
(DonIsaac)
- a438743 linter: Move `OxlintConfig` to `Oxlintrc` (#5707) (DonIsaac)
- f61e8b5 linter: Impl serde and schemars traits for `LintPlugins`
(#5706) (DonIsaac)
- 20a7861 linter: Shorten `Option` syntax (#5735) (overlookmotel)
- d8b612c oxc_linter: Prefer pass Enum instead of str `no_plus_plus`
(#5730) (IWANABETHATGUY)
- cc0408b semantic: S/AstNodeId/NodeId (#5740) (Boshen)

---------

Co-authored-by: Boshen <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant