refactor(linter): forbid string allocation methods such as to_lowercase and replace#5662
Closed
refactor(linter): forbid string allocation methods such as to_lowercase and replace#5662
to_lowercase and replace#5662Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-linter
…ase` and `replace`
Boshen
force-pushed
the
disallowed-methods
branch
from
6cd7dee to
d254435
Compare
CodSpeed Performance ReportMerging #5662 will not alter performanceComparing Summary
|
Contributor
|
I have found that these also exist in some test cases. Should we completely eliminate them? |
Member
Author
Don't bother if there are a lot, otherwise we should make tests a little bit faster as well. |
DonIsaac
approved these changes
Sep 10, 2024
DonIsaac
added
the
C-performance
Boshen
added a commit
that referenced
this pull request
Sep 11, 2024
Related to #5586 and #5662 --------- Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5586
Feel free to use the PR as the base and make changes.