Skip to content

Comments

test(transformer): move RegExp transform conformance tests#5536

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-06-test_transformer_move_regexp_transform_conformance_tests
Sep 6, 2024
Merged

test(transformer): move RegExp transform conformance tests#5536
graphite-app[bot] merged 1 commit intomainfrom
09-06-test_transformer_move_regexp_transform_conformance_tests

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 6, 2024

Rename transform conformance RegExp test fixtures folder from "esbuild-tests" to "regexp", to reflect that not all these tests are copied from ESBuild.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Sep 6, 2024
@overlookmotel overlookmotel marked this pull request as ready for review September 6, 2024 10:25
@overlookmotel overlookmotel force-pushed the 09-06-test_transformer_move_regexp_transform_conformance_tests branch from 7510309 to 71b2f2b Compare September 6, 2024 10:28
@overlookmotel overlookmotel changed the base branch from 09-06-refactor_transformer_regexp_transform_reuse_var to 09-05-docs_transformer_comment_on_regexp_transform_for_potential_improvement September 6, 2024 10:28
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #5536 will not alter performance

Comparing 09-06-test_transformer_move_regexp_transform_conformance_tests (e18c2ed) with main (fad0a05)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Sep 6, 2024 — with Graphite App
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 6, 2024

Merge activity

Rename transform conformance RegExp test fixtures folder from "esbuild-tests" to "regexp", to reflect that not all these tests are copied from ESBuild.
@Dunqing Dunqing force-pushed the 09-05-docs_transformer_comment_on_regexp_transform_for_potential_improvement branch from dae33d3 to 9282647 Compare September 6, 2024 12:04
@Dunqing Dunqing force-pushed the 09-06-test_transformer_move_regexp_transform_conformance_tests branch from 71b2f2b to e18c2ed Compare September 6, 2024 12:04
Base automatically changed from 09-05-docs_transformer_comment_on_regexp_transform_for_potential_improvement to main September 6, 2024 12:14
@graphite-app graphite-app bot merged commit e18c2ed into main Sep 6, 2024
@graphite-app graphite-app bot deleted the 09-06-test_transformer_move_regexp_transform_conformance_tests branch September 6, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants