refactor(transformer): break up RegExp transform into multiple functions#5511
Closed
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #5511 will not alter performanceComparing Summary
|
Member
Author
|
Well that doesn't work! 
|
Member
Author
|
My more minimal version which only moves all the logic into a separate function from A failed experiment! |
overlookmotel
deleted the
09-05-refactor_transformer_break_up_regexp_transform_into_multiple_functions
branch
This was referenced Sep 5, 2024
overlookmotel
restored the
09-05-refactor_transformer_break_up_regexp_transform_into_multiple_functions
branch
overlookmotel
deleted the
09-05-refactor_transformer_break_up_regexp_transform_into_multiple_functions
branch
This was referenced Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment. Idea is to split up the transform, with the heavy logic in separate functions, so potentially the compiler can inline the smaller "entry" functions.
enter_expressionis now tiny, andtransform_regexpalso quite short as it's all simple comparisons.transform_regexpcontains all the logic for bailing out quickly, so potentially the fast path for doing nothing could all get inlined.