Skip to content

Comments

chore(linter/vitest): improve docs for vitest rules#5428

Merged
DonIsaac merged 3 commits intooxc-project:mainfrom
shulaoda:chore/linter-vitest-docs
Sep 4, 2024
Merged

chore(linter/vitest): improve docs for vitest rules#5428
DonIsaac merged 3 commits intooxc-project:mainfrom
shulaoda:chore/linter-vitest-docs

Conversation

@shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Sep 3, 2024

          Please fill in the "why this is bad" section

Originally posted by @DonIsaac in #5360 (comment)

@github-actions github-actions bot added the A-linter Area - Linter label Sep 3, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 3, 2024

CodSpeed Performance Report

Merging #5428 will not alter performance

Comparing shulaoda:chore/linter-vitest-docs (b283bac) with main (e7bd49d)

Summary

✅ 28 untouched benchmarks

@shulaoda
Copy link
Contributor Author

shulaoda commented Sep 3, 2024

Should we wrap the document to make it clearer?

@DonIsaac
Copy link
Contributor

DonIsaac commented Sep 3, 2024

Beautiful.

@DonIsaac
Copy link
Contributor

DonIsaac commented Sep 3, 2024

Lmk when you're done making changes and I'll merge this.

@shulaoda
Copy link
Contributor Author

shulaoda commented Sep 4, 2024

Lmk when you're done making changes and I'll merge this.

I don't know how many lengths are suitable, perhaps we can also write a rule for this. I followed the rule you wrote before. @DonIsaac cc

@DonIsaac DonIsaac merged commit f89c776 into oxc-project:main Sep 4, 2024
@shulaoda shulaoda deleted the chore/linter-vitest-docs branch September 4, 2024 12:33
@shulaoda shulaoda mentioned this pull request Sep 25, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants