Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

• feat(ast): add and auto-generate WithBindingIdentifier trait #5362 👈
• feat(ast): add Function::name() #5361
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

CodSpeed Performance Report

Merging #5362 will not alter performance

_{Comparing don/08-30-feat_ast_ast_tools_add_getbindingidentifier_trait (cda09d4) with main (180b1a1)}

Summary

✅ 28 untouched benchmarks

adds a WithBindingIdentifier trait for accessing BindingIdentifiers on relevant AST nodes in a standard way.

Isn't this

adds a WithBindingIdentifier trait for accessing BindingIdentifiers on relevant AST nodes in a standard way.

Isn't this

oxc/crates/oxc_ast/src/syntax_directed_operations/bound_names.rs

Lines 3 to 10 in afb038e

	/// [`BoundName`](https://tc39.es/ecma262/#sec-static-semantics-boundnames)
	pub trait BoundName<'a> {
	fn bound_name<F: FnMut(&BindingIdentifier<'a>)>(&self, f: &mut F);
	}
	pub trait BoundNames<'a> {
	fn bound_names<F: FnMut(&BindingIdentifier<'a>)>(&self, f: &mut F);
	}

Just about... sigh...

I'm noticing that BoundNames isn't used at all in the linter, but decl.id.as_ref().and_then(|id| get_span_or_name_or_symbol_id(id)) is, maybe its an ergonomics thing? Especially if you want to get it as an option, you'll need to do this:

let mut id: Option<&BindingIdentifier<'a>> = None;
node.bound_names(|found| {
  debug_assert!(id.is_none());
  *id = Some(found)
}