refactor(linter)!: overhaul config and options#5333
Closed
DonIsaac wants to merge 1 commit intodon/08-29-feat_linter_implement_serialize_for_oxlintconfig_from
Closed
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Aug 30, 2024
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
DonIsaac
force-pushed
the
don/08-29-refactor_linter_overhaul_config_and_options
branch
from
cf32d0a to
dc45cdb
Compare
DonIsaac
changed the title
CodSpeed Performance ReportMerging #5333 will not alter performanceComparing Summary
|
Boshen
deleted the
don/08-29-refactor_linter_overhaul_config_and_options
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Does
Removes
OxlintConfigandOxlintOptionsin favor ofLinterBuilderandOxlintrc. Also adds support for plugins in config files. This should be the last preparation PR needed before I can finally tackle monorepo configs.Tl;Dr
OxlintConfighas been replaced withOxlintrc. This gets transformed byLinterBuilderinto internalLinterConfigandLinterOptionsobjects, which the rules andLintContextconsume.OxlintOptionswithLinterBuilder. Most fields in options are now inOxlintrc. Those that aren't (e.g. --fix) are settable via builder methods.LintPluginOptionsin favor ofLintPlugins. This makes the API much more succinct..oxlintrc.jsonfiles. The process is now:LinterBuilder. A default one is made when there's no file.