refactor(linter): add LintFilter#5329
Closed
DonIsaac wants to merge 1 commit intodon/08-23-refactor_linter_make_fields_of_lintserviceoptions_privatefrom
Closed
refactor(linter): add LintFilter#5329DonIsaac wants to merge 1 commit intodon/08-23-refactor_linter_make_fields_of_lintserviceoptions_privatefrom
LintFilter#5329DonIsaac wants to merge 1 commit intodon/08-23-refactor_linter_make_fields_of_lintserviceoptions_privatefrom
Conversation
This was referenced Aug 29, 2024
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #5329 will degrade performances by 4.72%Comparing Summary
Benchmarks breakdown
|
DonIsaac
force-pushed
the
don/08-29-refactor_linter_add_lintfilter_
branch
from
54b11b5 to
1c556df
Compare
DonIsaac
force-pushed
the
don/08-23-refactor_linter_make_fields_of_lintserviceoptions_private
branch
from
c2f27a0 to
eb7c9b9
Compare
DonIsaac
force-pushed
the
don/08-29-refactor_linter_add_lintfilter_
branch
from
1c556df to
f4881bd
Compare
DonIsaac
force-pushed
the
don/08-29-refactor_linter_add_lintfilter_
branch
from
f4881bd to
a512edc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formalizes
(AllowWarnDeny, String)intoLintFilterandLintFilterKind.Filters can be one of three variants:
category: for enabling/disabling an entire category. Corresponds to stringsthat are parseable into
RuleCategoryrule: for enabling/disabling an single rule. This variant also stores theplugin name. Corresponds to the string
<plugin>/<rule>generic: everything else."all"falls under this one.Note that if users use
<plugin>/<rule>filters that are malformed,oxlintwill now error. Missing plugins (e.g. for
vue/foobarwill have their pluginsparsed as "eslint" and fail silently. This is consistent with current behavior.