Skip to content

Comments

ci(benchmark/transformer): enable all > es6 plugins#5324

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-29-ci_benchmark_transformer_enable_all_es7_plugins
Aug 30, 2024
Merged

ci(benchmark/transformer): enable all > es6 plugins#5324
graphite-app[bot] merged 1 commit intomainfrom
08-29-ci_benchmark_transformer_enable_all_es7_plugins

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Aug 29, 2024 •
edited
Loading

There is a bug in the react refresh plugin, I will fix it in follow-up PR and enable the plugin in the benchmark

@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Aug 29, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@Dunqing Dunqing mentioned this pull request Aug 29, 2024
Merged
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Aug 29, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5324 will degrade performances by 62.13%

Comparing 08-29-ci_benchmark_transformer_enable_all_es7_plugins (783a31b) with main (8334bd4)

Summary

❌ 4 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 08-29-ci_benchmark_transformer_enable_all_es7_plugins Change
❌ transformer[RadixUIAdoptionSection.jsx] 98.3 µs 259.6 µs -62.13%
❌ transformer[antd.js] 26.3 ms 27.7 ms -5.24%
❌ transformer[checker.ts] 15.2 ms 27.5 ms -44.88%
❌ transformer[pdf.mjs] 4.8 ms 10.2 ms -53.55%

@Boshen Boshen changed the base branch from 08-29-feat_transformer_support_transformoptions_from_preset_env_api to graphite-base/5324 August 29, 2024 15:20
@Boshen Boshen force-pushed the graphite-base/5324 branch from d207417 to 0eb7602 Compare August 29, 2024 15:25
@Boshen Boshen force-pushed the 08-29-ci_benchmark_transformer_enable_all_es7_plugins branch from 18b59bb to c29cdb0 Compare August 29, 2024 15:25
@Boshen Boshen changed the base branch from graphite-base/5324 to main August 29, 2024 15:26
@Boshen Boshen force-pushed the 08-29-ci_benchmark_transformer_enable_all_es7_plugins branch from c29cdb0 to b0b7dbb Compare August 29, 2024 15:26
@Dunqing Dunqing force-pushed the 08-29-ci_benchmark_transformer_enable_all_es7_plugins branch 2 times, most recently from ec30b59 to 20bae29 Compare August 30, 2024 09:00
@Dunqing Dunqing changed the base branch from main to 08-30-feat_transformer_support_targets_from_query_method August 30, 2024 09:00
This was referenced Aug 30, 2024
Merged
Merged
@Dunqing Dunqing force-pushed the 08-30-feat_transformer_support_targets_from_query_method branch from 4e60f2b to b11c49e Compare August 30, 2024 09:09
@Dunqing Dunqing mentioned this pull request Aug 30, 2024
Merged
@Dunqing Dunqing force-pushed the 08-29-ci_benchmark_transformer_enable_all_es7_plugins branch from 20bae29 to 1699926 Compare August 30, 2024 09:10
@Dunqing Dunqing marked this pull request as ready for review August 30, 2024 09:12
@Boshen Boshen changed the title ci(benchmark/transformer): enable all >= es7 plugins ci(benchmark/transformer): enable all > es6 plugins Aug 30, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 30, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 30, 2024 •
edited
Loading

Merge activity

  • Aug 30, 5:29 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 30, 5:29 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Aug 30, 5:39 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Dunqing
ci(benchmark/transformer): enable all > es6 plugins (#5324)
783a31b 
There is a bug in the react refresh plugin, I will fix it in follow-up PR and enable the plugin in the benchmark
@Boshen Boshen force-pushed the 08-30-feat_transformer_support_targets_from_query_method branch from b11c49e to d04857b Compare August 30, 2024 09:31
@Boshen Boshen force-pushed the 08-29-ci_benchmark_transformer_enable_all_es7_plugins branch from 1699926 to 783a31b Compare August 30, 2024 09:32
Base automatically changed from 08-30-feat_transformer_support_targets_from_query_method to main August 30, 2024 09:38
@graphite-app graphite-app bot merged commit 783a31b into main Aug 30, 2024
@graphite-app graphite-app bot deleted the 08-29-ci_benchmark_transformer_enable_all_es7_plugins branch August 30, 2024 09:39
@overlookmotel overlookmotel mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dunqing @Boshen