• refactor(linter): use "parsed pattern" in no_div_regex rule. #5417
• feat(ast, parser): add oxc_regular_expression types to the parser and AST. #5256
• refactor(syntax): use generate_derive for CloneIn in types outside of oxc_ast crate. #5280
• feat(ast_tools): add dedicated Derive trait. #5278
• feat(regular_expression): implement Display for RegularExpression type. #5304 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite

CodSpeed Performance Report

Merging #5304 will not alter performance

_{Comparing 08-28-feat_regular_expression_implement_display_for_regularexpression_type (1d0bc62) with main (a1523c6)}

Summary

✅ 28 untouched benchmarks

@leaysgur A quick question. Shouldn't Character::value be u16? Isn't it always utf-16?

Sorry, I totally missed the Unicode mode.

Yes, all for Unicode mode.
(Feel free to ask anything!)

@rzvxa Boshen has added the merge label but I'm unclear if this is ready for merge or not. Not sure if the open comment threads need resolution or not.

Boshen added the merge label Aug 30, 2024 — with Graphite App

graphite acting on my behalf ... wtf

@leaysgur feel free to add the merge label for graphite to merge.

@leaysgur feel free to add the merge label for graphite to merge.

🫡

@rzvxa Please let me know when you're ready for the review~!

@leaysgur feel free to add the merge label for graphite to merge.

🫡

@rzvxa Please let me know when you're ready for the review~!

It should be ready for review, Let me know if there are any other issues.

@leaysgur Sorry I marked it as draft again, Found a panic while running conformance tests on #5256

@leaysgur OK it is ready, Sorry for the inconvenience.

@leaysgur Made the requested changes, Please give it another go.

Merge activity

• Sep 2, 9:56 PM EDT: @leaysgur we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

• Sep 2, 10:20 PM EDT: Boshen added this pull request to the Graphite merge queue.
• Sep 2, 10:28 PM EDT: Boshen merged this pull request with the Graphite merge queue.

Sorry, I've accidentally put a merge label on it!
And CI seems to be fail now, what happens in this case...?

Sorry, I've accidentally put a merge label on it! And CI seems to be fail now, what happens in this case...?

I added the merge label on the next PR. #5278

But CI passed?

@leaysgur FYI it won't get merged if CI fails even if we added the merge label.