improve(traverse)!: TraverseCtx::ancestors iterator do not yield Ancestor::None#5295
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 29, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
TraverseCtx::ancestors do not return Ancestor::NoneTraverseCtx::ancestors iterator do not yield Ancestor::None
TraverseCtx::ancestors iterator do not yield Ancestor::NoneTraverseCtx::ancestors iterator do not yield Ancestor::None
024f781 to
4b56879
Compare
068767f to
bd7d424
Compare
CodSpeed Performance ReportMerging #5295 will not alter performanceComparing Summary
|
4b56879 to
e656825
Compare
494836a to
870fab0
Compare
e656825 to
7fdf6e6
Compare
870fab0 to
bfdf5ed
Compare
7fdf6e6 to
445d9f8
Compare
bfdf5ed to
7432d25
Compare
8738017 to
099d7b2
Compare
7432d25 to
cdbc60d
Compare
cdbc60d to
0cf76d5
Compare
099d7b2 to
23e8456
Compare
0cf76d5 to
8ecbb8f
Compare
Contributor
Merge activity
|
…ncestor::None` (#5295) `TraverseCtx::ancestors` iterator would previously yield `Some(Ancestor::None)` before finally yielding `None`. Skip `Ancestor::None` as it's pointless.
8ecbb8f to
da8aa18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TraverseCtx::ancestorsiterator would previously yieldSome(Ancestor::None)before finally yieldingNone. SkipAncestor::Noneas it's pointless.