Skip to content

Comments

improve(traverse)!: TraverseCtx::ancestors iterator do not yield Ancestor::None#5295

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-28-refactor_traverse_traversectx_ancestors_do_not_return_ancestor_none_
Aug 29, 2024
Merged

improve(traverse)!: TraverseCtx::ancestors iterator do not yield Ancestor::None#5295
graphite-app[bot] merged 1 commit intomainfrom
08-28-refactor_traverse_traversectx_ancestors_do_not_return_ancestor_none_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 28, 2024

TraverseCtx::ancestors iterator would previously yield Some(Ancestor::None) before finally yielding None. Skip Ancestor::None as it's pointless.

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Aug 28, 2024

@overlookmotel overlookmotel marked this pull request as ready for review August 28, 2024 11:39
@overlookmotel overlookmotel changed the title refactor(traverse)!: TraverseCtx::ancestors do not return Ancestor::None refactor(traverse)!: TraverseCtx::ancestors iterator do not yield Ancestor::None Aug 28, 2024
@overlookmotel overlookmotel changed the title refactor(traverse)!: TraverseCtx::ancestors iterator do not yield Ancestor::None improve(traverse)!: TraverseCtx::ancestors iterator do not yield Ancestor::None Aug 28, 2024
@overlookmotel overlookmotel force-pushed the 08-28-fix_traverse_traversectx_ancestor_with_level_0_equivalent_to_parent_ branch from 024f781 to 4b56879 Compare August 28, 2024 11:43
@overlookmotel overlookmotel force-pushed the 08-28-refactor_traverse_traversectx_ancestors_do_not_return_ancestor_none_ branch from 068767f to bd7d424 Compare August 28, 2024 11:44
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 28, 2024

CodSpeed Performance Report

Merging #5295 will not alter performance

Comparing 08-28-refactor_traverse_traversectx_ancestors_do_not_return_ancestor_none_ (da8aa18) with main (23e8456)

Summary

✅ 28 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 08-28-fix_traverse_traversectx_ancestor_with_level_0_equivalent_to_parent_ branch from 4b56879 to e656825 Compare August 28, 2024 11:58
@overlookmotel overlookmotel force-pushed the 08-28-refactor_traverse_traversectx_ancestors_do_not_return_ancestor_none_ branch 2 times, most recently from 494836a to 870fab0 Compare August 28, 2024 12:08
@overlookmotel overlookmotel force-pushed the 08-28-fix_traverse_traversectx_ancestor_with_level_0_equivalent_to_parent_ branch from e656825 to 7fdf6e6 Compare August 28, 2024 12:38
@overlookmotel overlookmotel force-pushed the 08-28-refactor_traverse_traversectx_ancestors_do_not_return_ancestor_none_ branch from 870fab0 to bfdf5ed Compare August 28, 2024 12:38
@overlookmotel overlookmotel force-pushed the 08-28-fix_traverse_traversectx_ancestor_with_level_0_equivalent_to_parent_ branch from 7fdf6e6 to 445d9f8 Compare August 28, 2024 13:05
@overlookmotel overlookmotel force-pushed the 08-28-refactor_traverse_traversectx_ancestors_do_not_return_ancestor_none_ branch from bfdf5ed to 7432d25 Compare August 28, 2024 13:06
@overlookmotel overlookmotel force-pushed the 08-28-fix_traverse_traversectx_ancestor_with_level_0_equivalent_to_parent_ branch 2 times, most recently from 8738017 to 099d7b2 Compare August 28, 2024 14:14
@overlookmotel overlookmotel force-pushed the 08-28-refactor_traverse_traversectx_ancestors_do_not_return_ancestor_none_ branch from 7432d25 to cdbc60d Compare August 28, 2024 14:14
@overlookmotel overlookmotel changed the base branch from 08-28-fix_traverse_traversectx_ancestor_with_level_0_equivalent_to_parent_ to graphite-base/5295 August 29, 2024 08:52
@overlookmotel overlookmotel force-pushed the 08-28-refactor_traverse_traversectx_ancestors_do_not_return_ancestor_none_ branch from cdbc60d to 0cf76d5 Compare August 29, 2024 08:56
@overlookmotel overlookmotel changed the base branch from graphite-base/5295 to main August 29, 2024 08:56
@overlookmotel overlookmotel force-pushed the 08-28-refactor_traverse_traversectx_ancestors_do_not_return_ancestor_none_ branch from 0cf76d5 to 8ecbb8f Compare August 29, 2024 08:57
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 29, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 29, 2024

Merge activity

  • Aug 29, 5:21 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 29, 5:21 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Aug 29, 5:27 AM EDT: Boshen merged this pull request with the Graphite merge queue.

…ncestor::None` (#5295)

`TraverseCtx::ancestors` iterator would previously yield `Some(Ancestor::None)` before finally yielding `None`. Skip `Ancestor::None` as it's pointless.
@Boshen Boshen force-pushed the 08-28-refactor_traverse_traversectx_ancestors_do_not_return_ancestor_none_ branch from 8ecbb8f to da8aa18 Compare August 29, 2024 09:22
@graphite-app graphite-app bot merged commit da8aa18 into main Aug 29, 2024
@graphite-app graphite-app bot deleted the 08-28-refactor_traverse_traversectx_ancestors_do_not_return_ancestor_none_ branch August 29, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants