Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

• perf(traverse): store Ancestor parts as SoA #5284 👈
• improve(traverse)!: TraverseCtx::ancestors iterator do not yield Ancestor::None #5295
• fix(traverse)!: TraverseCtx::ancestor with level 0 = equivalent to parent #5294
• ci: enable arithmetic overflow checks in conformance tests #5296
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

CodSpeed Performance Report

Merging #5284 will not alter performance

_{Comparing 08-27-perf_traverse_store_ancestor_parts_as_soa (835256c) with main (91b39c4)}

Summary

✅ 29 untouched benchmarks

A 1% perf bump. Perhaps not worth it for the amount of unsafe code. But probably would have more effect for a larger Vec of enums like Vec<AstKind>.

A 1% perf bump. Perhaps not worth it for the amount of unsafe code. But probably would have more effect for a larger Vec of enums like Vec<AstKind>.

Currently, only benchmark typescript plugin, if benchmark all the plugins, may have more perf bump

If we were going to do this, we'd better off implementing an SoA mechanism which we use everywhere (e.g. Semantic's SoA structures). So closing this and may come back to it in future.