Skip to content

Comments

fix(linter/no-unused-vars): function expression in implicit arrow function return#5155

Merged
graphite-app[bot] merged 1 commit intomainfrom
don/08-23-fix_linter/no-unused-vars_function_expression_in_implicit_arrow_function_return
Aug 24, 2024
Merged

fix(linter/no-unused-vars): function expression in implicit arrow function return#5155
graphite-app[bot] merged 1 commit intomainfrom
don/08-23-fix_linter/no-unused-vars_function_expression_in_implicit_arrow_function_return

Conversation

@DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Aug 23, 2024

Fixes cases such as:

export const foo = () => function bar() {}

Copy link
Contributor Author

DonIsaac commented Aug 23, 2024

@github-actions github-actions bot added the A-linter Area - Linter label Aug 23, 2024
@DonIsaac DonIsaac marked this pull request as ready for review August 23, 2024 22:28
@DonIsaac DonIsaac added the C-bug Category - Bug label Aug 23, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 23, 2024

CodSpeed Performance Report

Merging #5155 will not alter performance

Comparing don/08-23-fix_linter/no-unused-vars_function_expression_in_implicit_arrow_function_return (d29042e) with main (147b371)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac requested a review from Boshen August 24, 2024 15:48
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 24, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 24, 2024

Merge activity

  • Aug 24, 11:49 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 24, 11:49 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Aug 24, 11:54 AM EDT: Boshen merged this pull request with the Graphite merge queue.

…ction return (#5155)

Fixes cases such as:
```ts
export const foo = () => function bar() {}
```
@Boshen Boshen force-pushed the don/08-23-fix_linter/no-unused-vars_function_expression_in_implicit_arrow_function_return branch from 8833061 to d29042e Compare August 24, 2024 15:50
@graphite-app graphite-app bot merged commit d29042e into main Aug 24, 2024
@graphite-app graphite-app bot deleted the don/08-23-fix_linter/no-unused-vars_function_expression_in_implicit_arrow_function_return branch August 24, 2024 15:54
@oxc-bot oxc-bot mentioned this pull request Aug 26, 2024
Boshen added a commit that referenced this pull request Aug 26, 2024
## [0.9.0] - 2024-08-26

- 5946748 linter: [**BREAKING**] Parse and display syntax errors for
regular expressions (#5214) (Boshen)

- b894d3b linter: [**BREAKING**] Make `no-unused-vars` correctness
(#5081) (DonIsaac)

### Features

- 1ce9630 linter/config: Implement FromIterator for LintPluginOptions
(#5102) (DonIsaac)
- 34bfaf6 linter/react: Add fixer to `jsx-props-no-spread-multi` (#5145)
(camc314)
- 982bd6e linter/unicorn: Add fixer to `require-array-join-separator`
(#5152) (camc314)
- a6704bd linter/unicorn: Add fixer to `prefer-set-size` (#5149)
(camc314)
- ac7edcc linter/unicorn: Add fixer to `prefer-array-some` (#5153)
(camc314)
- 1d01aa3 linter/unicorn: Add partial fixer for `prefer-array-flat`
(#5143) (camc314)
- 22d57f9 linter/unicorn: Add fixer to `prefer-string-slice` (#5150)
(Cameron)
- 2fe4415 linter/unicorn: Add fixer to `no-redundant-roles` (#5146)
(Cameron)
- d35c6f5 linter/unicorn: Add fixer to `prefer-regexp-test` (#5151)
(Cameron)
- 27db769 linter/unicorn: Add fixer to `text-encoding-identifier-case`
(#5154) (Cameron)
- f7958c4 linter/unicorn: Add prefer-structured-clone (#5095) (Jelle van
der Waa)
- 004ffa0 linter/vitest: Implement `prefer-each` (#5203) (dalaoshu)

### Bug Fixes

- aaaf26c linter: Error in fixer for prefer-to-have-length (#5197)
(dalaoshu)
- 1f5b6b6 linter: Bug in fixer for prefer-to-have-length (#5164)
(dalaoshu)
- 7eb052e linter: `no-hex-escape` fixer removing regex flags (#5137)
(Cameron)
- 76c66b4 linter/max-lines: Point span to end of file for disable
directive to work (#5117) (Boshen)
- 8ff6f2c linter/no-unused-vars: Panic on UsingDeclarations (#5206)
(DonIsaac)
- d29042e linter/no-unused-vars: Function expression in implicit arrow
function return (#5155) (DonIsaac)
- 36e4a28 linter/no-unused-vars: Panic in variable declarator usage
checks (#5160) (DonIsaac)
- ba62a71 linter/react: Fixed false positive with missing key inside
React.Children.toArray() for fragments (#5133) (Earl Chase)
- fd1031a linter/unicorn: Breaking fixer in case statements for
`no-null` (#5176) (DonIsaac)
- 7b86ed6 linter/unicorn: Handle type casts and parens in `no-null`
(#5175) (Don Isaac)
- b629e16 linter/unicorn: Improve diagnostic message for `no-null`
(#5172) (DonIsaac)

### Performance
- ce454cf Use simdutf8 to validate UTF-8 when reading files (#5196)
(dalaoshu)

### Refactor

- 543cad6 codegen: Remove some pub APIs (Boshen)
- 0d3661a linter: Remove meaningless `span0` (#5209) (dalaoshu)
- 2a91ef1 linter: `eslint/no_redeclare` rule use `run_on_symbol` not
`run_once` (#5201) (overlookmotel)
- 33599b0 linter: Split options into multiple files (#5101) (DonIsaac)
- 7ab6152 linter/unicorn: Clean up `no-null` (#5174) (DonIsaac)

### Testing

- a877e5a linter/no-unused-vars: Ensure type annotations on property
accessors are considered used (#5183) (DonIsaac)
- 7886618 linter/unicorn: Add fixer tests for `no-null` (#5173)
(DonIsaac)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants