Skip to content

Comments

feat(linter/promise): add spec-only rule#5124

Merged
DonIsaac merged 2 commits intooxc-project:mainfrom
jelly:promise-spec-only
Aug 31, 2024
Merged

feat(linter/promise): add spec-only rule#5124
DonIsaac merged 2 commits intooxc-project:mainfrom
jelly:promise-spec-only

Conversation

@jelly
Copy link
Contributor

@jelly jelly commented Aug 23, 2024

Rule Detail:

link

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Aug 23, 2024
@jelly jelly force-pushed the promise-spec-only branch 2 times, most recently from efab265 to 2651e23 Compare August 23, 2024 12:12
@jelly
Copy link
Contributor Author

jelly commented Aug 23, 2024

Not sure what:

---- size_asserts stdout ----
thread 'size_asserts' panicked at crates/oxc_linter/src/lib.rs:50:5:
assertion failed: std::mem::size_of::<RuleEnum>() == 16

Is about?

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 23, 2024

CodSpeed Performance Report

Merging #5124 will not alter performance

Comparing jelly:promise-spec-only (edd7fb7) with main (35f03db)

Summary

✅ 28 untouched benchmarks

@jelly jelly force-pushed the promise-spec-only branch from 2651e23 to aa597cc Compare August 23, 2024 19:43
@DonIsaac DonIsaac added the C-enhancement Category - New feature or request label Aug 26, 2024
@jelly jelly requested a review from camc314 August 31, 2024 10:08
@DonIsaac DonIsaac changed the title feat(linter/eslint-plugin-promise): implement spec-only feat(linter/promise): add spec-only rule Aug 31, 2024
@DonIsaac DonIsaac merged commit e5c755a into oxc-project:main Aug 31, 2024
@jelly jelly deleted the promise-spec-only branch August 31, 2024 15:56
@oxc-bot oxc-bot mentioned this pull request Sep 2, 2024
Boshen added a commit that referenced this pull request Sep 2, 2024
## [0.9.2] - 2024-09-02

### Features

- f81e8a1 linter: Add `oxc/no-async-endpoint-handlers` (#5364)
(DonIsaac)
- b103737 linter: Improve no-accumulating-spread (#5302) (camc314)
- 9c22ce9 linter: Add hyperlinks to diagnostic messages (#5318)
(DonIsaac)
- 1967c67 linter/eslint: Implement no-new-func (#5360) (dalaoshu)
- b867e5f linter/eslint-plugin-promise: Implement catch-or-return
(#5121) (Jelle van der Waa)
- 8d781e7 linter/oxc: Differentiate between array/object in
`no-accumulating-spread` loop diagnostic (#5375) (camc314)
- db55444 linter/oxc: Add fixer for `double-comparisons` (#5378)
(camc314)
- e5c755a linter/promise: Add `spec-only` rule (#5124) (Jelle van der
Waa)
- 4c0861f linter/unicorn: Add fixer for `prefer-type-error` (#5311)
(camc314)
- 084c2d1 linter/vitest: Implement prefer-to-be-object (#5321)
(dalaoshu)

### Bug Fixes

- 11b93af linter/unicorn: Consistent-function-scoping false positive on
assignment expression (#5312) (Arian94)

### Performance

- f052a6d linter: `react/jsx_no_undef` faster check for unbound
references (#5349) (overlookmotel)
- 05636b7 linter: Avoid unnecessary work in `jsx_a11y/anchor_is_valid`
rule (#5341) (overlookmotel)

### Refactor

- afb038e linter: `react/jsx_no_undef` use loop instead of recursion
(#5347) (overlookmotel)
- fe62687 linter: Simplify skipping JSX elements in
`unicorn/consistent_function_scoping` (#5351) (overlookmotel)
- 381d9fe linter: Shorten code in `react/jsx_no_useless_fragment`
(#5350) (overlookmotel)
- 83b9a82 linter: Fix indentation in
`nextjs/no_script_component_in_head` rule (#5338) (overlookmotel)
- 89f0188 linter: Improve docs for `react/jsx_no_target_blank` rule
(#5342) (overlookmotel)
- 57050ab linter: Shorten code in
`jsx_a11y/aria_activedescendant_has_tabindex` rule (#5340)
(overlookmotel)
- ed31d67 linter/jest: Fix indentation in code comment (#5372) (camc314)
- 2499cb9 linter/oxc: Update rule docs for `erasing-op` (#5376)
(camc314)
- 69493d2 linter/oxc: Improve diagnostic for `no-accumulating-spread` in
loops (#5374) (camc314)
- 024b585 linter/oxc: Improve code comment for `no-accumulating-spread`
(#5373) (camc314)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants