• refactor(website): rename fields in Playground from flag to flags #5033 👈
• refactor(semantic): rename fields in snapshots from flag to flags #5032
• refactor(semantic): rename vars from flag to flags #5031
• refactor(semantic)!: rename SymbolTable::get_flag to get_flags #5030
• refactor(linter, mangler, parser, semantic, transformer, traverse, wasm): rename various flag vars to flags #5028
• refactor(semantic): rename SemanticBuilder::current_reference_flags field #5027
• refactor(semantic): rename Reference::flag field to flags #5026
• refactor(semantic)!: rename Reference::flag and flag_mut methods to plural #5025
• refactor(ast)!: rename IdentifierReference::reference_flags field #5024
• refactor(syntax)!: rename ReferenceFlag to ReferenceFlags #5023
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

@DonIsaac I'm not familiar with playground, and I'm not sure if it's tested in CI. Does this look like it'd cause any problems?

PS: This concludes my one-man war on "flag"!

@DonIsaac I'm not familiar with playground, and I'm not sure if it's tested in CI. Does this look like it'd cause any problems?

It's possible; I can test it out locally.

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Approved, but please don't merge this yet

Approved, but please don't merge this yet

OK cool. I'm off to bed. I'm not sure of the reason for saying "don't merge this yet". If whatever question/problem is the blocker is resolved/becomes clear, if you have the energy/bandwidth, and you think the stack as a whole is OK, please can you merge it? But if any problems or queries outstanding, no worries - just let me know and I'll pick it up tomorrow.

Or just leave it and enjoy your evening!

LGTM

Merge activity

• Aug 20, 8:15 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 20, 8:15 PM EDT: Boshen added this pull request to the Graphite merge queue.
• Aug 20, 8:46 PM EDT: Boshen merged this pull request with the Graphite merge queue.