Skip to content

Comments

fix(linter): change consistent-function-scoping back to correctness#5016

Closed
DonIsaac wants to merge 1 commit intomainfrom
don/08-20-fix_linter_change_consistent-function-scoping_back_to_correctness
Closed

fix(linter): change consistent-function-scoping back to correctness#5016
DonIsaac wants to merge 1 commit intomainfrom
don/08-20-fix_linter_change_consistent-function-scoping_back_to_correctness

Conversation

@DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Aug 20, 2024

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 20, 2024

CodSpeed Performance Report

Merging #5016 will not alter performance

Comparing don/08-20-fix_linter_change_consistent-function-scoping_back_to_correctness (662244e) with main (cd9f1cd)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac marked this pull request as draft August 20, 2024 16:21
@DonIsaac DonIsaac force-pushed the don/08-20-docs_linter/consistent-function-scoping_improve_rule_documentation branch 2 times, most recently from 7f8609a to dd8e2a1 Compare August 20, 2024 16:27
@DonIsaac DonIsaac force-pushed the don/08-20-fix_linter_change_consistent-function-scoping_back_to_correctness branch 2 times, most recently from a51f6ab to 1793b7f Compare August 20, 2024 16:27
@DonIsaac DonIsaac force-pushed the don/08-20-docs_linter/consistent-function-scoping_improve_rule_documentation branch from dd8e2a1 to 9e4c130 Compare August 20, 2024 21:01
@DonIsaac DonIsaac force-pushed the don/08-20-fix_linter_change_consistent-function-scoping_back_to_correctness branch from 1793b7f to 6b26bbe Compare August 20, 2024 21:01
@Boshen Boshen changed the base branch from don/08-20-docs_linter/consistent-function-scoping_improve_rule_documentation to graphite-base/5016 August 21, 2024 00:47
@Boshen Boshen force-pushed the graphite-base/5016 branch from 9e4c130 to cd9f1cd Compare August 21, 2024 01:07
@Boshen Boshen force-pushed the don/08-20-fix_linter_change_consistent-function-scoping_back_to_correctness branch from 6b26bbe to 7cd4ba9 Compare August 21, 2024 01:07
@Boshen Boshen changed the base branch from graphite-base/5016 to main August 21, 2024 01:08
@Boshen Boshen force-pushed the don/08-20-fix_linter_change_consistent-function-scoping_back_to_correctness branch from 7cd4ba9 to 662244e Compare August 21, 2024 01:08
@DonIsaac DonIsaac closed this Aug 21, 2024
@Boshen Boshen deleted the don/08-20-fix_linter_change_consistent-function-scoping_back_to_correctness branch September 11, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant