Skip to content

Comments

chore: remove oncecell dep#4864

Closed
IWANABETHATGUY wants to merge 1 commit intomainfrom
fix/remove-once-cell-dep
Closed

chore: remove oncecell dep#4864
IWANABETHATGUY wants to merge 1 commit intomainfrom
fix/remove-once-cell-dep

Conversation

@IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Aug 13, 2024

  1. Remove the dependency of once_cell

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-codegen Area - Code Generation labels Aug 13, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 13, 2024

CodSpeed Performance Report

Merging #4864 will not alter performance

Comparing fix/remove-once-cell-dep (fdf6ae9) with main (1808529)

Summary

✅ 29 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Aug 13, 2024

This raises our msrv (minimal supported rust version) to v1.80.0, which isn't nice for crate consumers :-(

@IWANABETHATGUY
Copy link
Contributor Author

This raises our msrv (minimal supported rust version) to v1.80.0, which isn't nice for crate consumers :-(

I see

@Boshen Boshen deleted the fix/remove-once-cell-dep branch August 13, 2024 07:25
@rzvxa
Copy link
Contributor

rzvxa commented Aug 13, 2024

This raises our msrv (minimal supported rust version) to v1.80.0, which isn't nice for crate consumers :-(

We already have msrv of 1.80.0, take a look at this:
https://discord.com/channels/1079625926024900739/1117322804291964931/1272270360263266367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants