refactor(ast_codegen): trim r# from start of field names#4785
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 9, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Aug 9, 2024
Member
Author
This was referenced Aug 9, 2024
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_alter_json_schema_format
branch
from
7045345 to
b7f9308
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_trim_r_from_start_of_field_names
branch
from
30a0e0d to
8f24957
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_alter_json_schema_format
branch
from
b7f9308 to
d074353
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_trim_r_from_start_of_field_names
branch
from
8f24957 to
b428568
Compare
CodSpeed Performance ReportMerging #4785 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_alter_json_schema_format
branch
from
d074353 to
7ab0783
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_trim_r_from_start_of_field_names
branch
from
b428568 to
875a9cb
Compare
rzvxa
approved these changes
Aug 9, 2024
Contributor
Merge activity
|
Some struct fields are reserved names e.g. `type`. They are written in source as `r#type`. Trim off the `r#` prefix in `FieldDef::name` and add it back when generating output. Main motivation is to have the unescaped field names in JSON schema.
rzvxa
force-pushed
the
08-09-refactor_ast_codegen_alter_json_schema_format
branch
from
7ab0783 to
3131187
Compare
rzvxa
force-pushed
the
08-09-refactor_ast_codegen_trim_r_from_start_of_field_names
branch
from
875a9cb to
ec82a79
Compare
Base automatically changed from
08-09-refactor_ast_codegen_alter_json_schema_format
to
main
August 9, 2024 10:56
graphite-app
bot
deleted the
08-09-refactor_ast_codegen_trim_r_from_start_of_field_names
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some struct fields are reserved names e.g.
type. They are written in source asr#type. Trim off ther#prefix inFieldDef::nameand add it back when generating output.Main motivation is to have the unescaped field names in JSON schema.