refactor(ast_codegen): remove excess space from start of doc comments#4782
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 9, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Aug 9, 2024
Member
Author
CodSpeed Performance ReportMerging #4782 will not alter performanceComparing Summary
|
rzvxa
approved these changes
Aug 9, 2024
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions
branch
from
627d746 to
5e6870c
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments
branch
from
de08832 to
d138825
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions
branch
from
5e6870c to
9c9175a
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments
branch
2 times, most recently
from
ba02f27 to
39177c9
Compare
Contributor
Merge activity
|
overlookmotel
changed the base branch from
08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions
to
graphite-base/4782
…#4782) I noticed that in JSON schema the `docs` property contains e.g. `" The name of the identifier being referenced."` (with an excess space on the start). Trim that off.
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments
branch
from
39177c9 to
c79ca40
Compare
graphite-app
bot
deleted the
08-09-refactor_ast_codegen_remove_excess_space_from_start_of_doc_comments
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in JSON schema the
docsproperty contains e.g." The name of the identifier being referenced."(with an excess space on the start). Trim that off.