refactor(ast_codegen): line breaks between types in layout assertions#4781
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 9, 2024
Conversation
This was referenced Aug 9, 2024
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Aug 9, 2024
Member
Author
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_
branch
from
a861c31 to
1e25ab5
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions
branch
from
89d980d to
f6cd942
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_
branch
from
1e25ab5 to
992f1cd
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions
branch
from
f6cd942 to
e65885d
Compare
overlookmotel
changed the base branch from
08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_
to
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
branch
from
e126245 to
58bc0de
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions
branch
from
e65885d to
a9fcafe
Compare
CodSpeed Performance ReportMerging #4781 will not alter performanceComparing Summary
|
rzvxa
approved these changes
Aug 9, 2024
Contributor
rzvxa
left a comment
rzvxa
left a comment
There was a problem hiding this comment.
I like the idea, However, I've made some comments on the insert! macro PR.
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
branch
from
58bc0de to
94a6edc
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions
branch
from
a9fcafe to
0f30bd3
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
branch
from
94a6edc to
601ba35
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions
branch
from
0f30bd3 to
627d746
Compare
This was referenced Aug 9, 2024
Contributor
Merge activity
|
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
branch
from
601ba35 to
7bf49b8
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions
branch
from
627d746 to
5e6870c
Compare
overlookmotel
changed the base branch from
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
to
graphite-base/4781
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions
branch
from
5e6870c to
9c9175a
Compare
overlookmotel
force-pushed
the
graphite-base/4781
branch
from
7bf49b8 to
966fcc9
Compare
…#4781) Small style nit. Add line breaks between types in generated layout assertions, to make the file easier to read.
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions
branch
from
9c9175a to
d4a3be8
Compare
graphite-app
bot
deleted the
08-09-refactor_ast_codegen_line_breaks_between_types_in_layout_assertions
branch
Merged
Boshen
added a commit
that referenced
this pull request
Aug 10, 2024
## [0.24.1] - 2024-08-10 ### Features - b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac) - c519295 minifier: Add `InjectGlobalVariables` plugin (`@rollup/plugin-inject`) (#4759) (Boshen) ### Bug Fixes - fff9da3 ast, ast_codegen: Use `generate_derive` instead of visitable for generating span derives. (#4747) (rzvxa) - f5eeebd ast_macros: Raise compile error on invalid `generate_derive` input. (#4766) (rzvxa) - 4d0b40a napi/transform: Fix wrong isolated declarations emit (Boshen) ### Refactor - daa0b2e ast: `oxc_ast` crate re-export AST types from other crates (#4773) (overlookmotel) - d4a3be8 ast_codegen: Line breaks between types in layout assertions (#4781) (overlookmotel) - dbb5f4c ast_codegen: Remove unnecessary imports from generated files (#4774) (overlookmotel) - 7ea058d ast_codegen: Replace Windows-style line breaks with Unix-style (#4769) (overlookmotel) - 2dea0ca ast_codegen: Consistent import order (#4761) (overlookmotel) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small style nit. Add line breaks between types in generated layout assertions, to make the file easier to read.