refactor(ast_codegen): re-order code in fmt module#4779
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 9, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Aug 9, 2024
Member
Author
CodSpeed Performance ReportMerging #4779 will not alter performanceComparing Summary
|
rzvxa
force-pushed
the
08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_
branch
from
93546af to
9c53522
Compare
rzvxa
force-pushed
the
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
branch
from
790dd61 to
080b84d
Compare
rzvxa
approved these changes
Aug 9, 2024
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_
branch
from
9c53522 to
a861c31
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_
branch
from
a861c31 to
1e25ab5
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
branch
from
080b84d to
f3470bb
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_
branch
from
1e25ab5 to
992f1cd
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
branch
from
f3470bb to
e126245
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_
branch
from
992f1cd to
2562cd7
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
branch
from
e126245 to
58bc0de
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_
branch
from
2562cd7 to
e0d978c
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
branch
2 times, most recently
from
94a6edc to
601ba35
Compare
This was referenced Aug 9, 2024
overlookmotel
changed the base branch from
08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_
to
graphite-base/4779
Contributor
Merge activity
|
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
branch
from
601ba35 to
7bf49b8
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
branch
from
7bf49b8 to
966fcc9
Compare
graphite-app
bot
deleted the
08-09-refactor_ast_codegen_re-order_code_in_fmt_module
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Just move code which is most used to top of
fmtmodule. And renamepprinttopretty_printto be a little clearer.