refactor(ast): oxc_ast crate re-export AST types from other crates#4773
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 9, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
Member
Author
CodSpeed Performance ReportMerging #4773 will not alter performanceComparing Summary
|
This was referenced Aug 9, 2024
overlookmotel
force-pushed
the
08-09-refactor_ast_oxc_ast_crate_re-export_ast_types_from_other_crates
branch
from
2b79f16 to
c697c35
Compare
This was referenced Aug 9, 2024
rzvxa
approved these changes
Aug 9, 2024
Contributor
rzvxa
left a comment
rzvxa
left a comment
There was a problem hiding this comment.
Good call, I think we should move stuff out of oxc_span later on. Atom makes sense to be there but I can't say the same thing for the SourceType and its sub-types.
This PR helps if we want to do that.
Contributor
Merge activity
|
…4773) Some AST types are defined in crates outside `oxc_ast` crate. Re-export these types from `oxc_ast` crate for ease - so you don't need to remember where they're defined to use them.
rzvxa
force-pushed
the
08-09-refactor_ast_oxc_ast_crate_re-export_ast_types_from_other_crates
branch
from
c697c35 to
daa0b2e
Compare
graphite-app
bot
deleted the
08-09-refactor_ast_oxc_ast_crate_re-export_ast_types_from_other_crates
branch
Member
Author
|
Thanks both for reviewing. |
rzvxa
pushed a commit
that referenced
this pull request
Aug 9, 2024
#4774) #4773 makes types like `Span` importable from `oxc_ast::ast`, so remove the imports from other crates in generated code. I'm not sure why clippy's `wildcard_imports` rule was not being triggered for `use crate::ast::*;`, but add `#[allow(clippy::wildcard_imports)]` on these statements just to make sure.
This was referenced Aug 9, 2024
Merged
Boshen
added a commit
that referenced
this pull request
Aug 10, 2024
## [0.24.1] - 2024-08-10 ### Features - b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac) - c519295 minifier: Add `InjectGlobalVariables` plugin (`@rollup/plugin-inject`) (#4759) (Boshen) ### Bug Fixes - fff9da3 ast, ast_codegen: Use `generate_derive` instead of visitable for generating span derives. (#4747) (rzvxa) - f5eeebd ast_macros: Raise compile error on invalid `generate_derive` input. (#4766) (rzvxa) - 4d0b40a napi/transform: Fix wrong isolated declarations emit (Boshen) ### Refactor - daa0b2e ast: `oxc_ast` crate re-export AST types from other crates (#4773) (overlookmotel) - d4a3be8 ast_codegen: Line breaks between types in layout assertions (#4781) (overlookmotel) - dbb5f4c ast_codegen: Remove unnecessary imports from generated files (#4774) (overlookmotel) - 7ea058d ast_codegen: Replace Windows-style line breaks with Unix-style (#4769) (overlookmotel) - 2dea0ca ast_codegen: Consistent import order (#4761) (overlookmotel) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some AST types are defined in crates outside
oxc_astcrate. Re-export these types fromoxc_astcrate for ease - so you don't need to remember where they're defined to use them.