refactor(ast_codegen): remove Generator::name and Pass::name methods#4764
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
overlookmotel
force-pushed
the
08-08-refactor_ast_codegen_remove_generator_name_method
branch
from
2f8e7cb to
a19de15
Compare
overlookmotel
changed the title
Generator::name methodGenerator::name and Pass::name methods
CodSpeed Performance ReportMerging #4764 will not alter performanceComparing Summary
|
rzvxa
left a comment
rzvxa
left a comment
There was a problem hiding this comment.
I use this method to allow custom identifiers for generators/passes.
I leverage this for generating debug information.
.pass(AssertX("Test1"))
.pass(YYY)
.pass(AssertX("Test2"))At the moment it doesn't have any use upstream but is useful for local development.
However, I can implement those manually. It doesn't have to go through the macro.
Merge activity
|
…ods (#4764) Remove `Generator::name` and `Pass::name` methods. All impls for these methods return a string identical to the struct name, so can set return value of `Runner::name` in `define_generator!` and `define_pass!` macros instead.
rzvxa
force-pushed
the
08-08-refactor_ast_codegen_re-order_imports
branch
from
3859fae to
d32fb6f
Compare
rzvxa
force-pushed
the
08-08-refactor_ast_codegen_remove_generator_name_method
branch
from
a19de15 to
7345f68
Compare
graphite-app
bot
deleted the
08-08-refactor_ast_codegen_remove_generator_name_method
branch
I can't say I understand you. But feel free to revert this if those methods are actually useful. I just couldn't see them being used anywhere at present, but I may well be missing some context. |
2 participants
Remove
Generator::nameandPass::namemethods. All impls for these methods return a string identical to the struct name, so can set return value ofRunner::nameindefine_generator!anddefine_pass!macros instead.