Skip to content

Comments

refactor(ast_codegen): consistent endl! position#4762

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-08-refactor_ast_codegen_consistent_endl_position
Aug 8, 2024
Merged

refactor(ast_codegen): consistent endl! position#4762
graphite-app[bot] merged 1 commit intomainfrom
08-08-refactor_ast_codegen_consistent_endl_position

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 8, 2024

Pure refactor (style nit). Place endl!() macro calls in consistent position throughout codegen.

Copy link
Member Author

overlookmotel commented Aug 8, 2024

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 8, 2024

CodSpeed Performance Report

Merging #4762 will not alter performance

Comparing 08-08-refactor_ast_codegen_consistent_endl_position (80046d1) with main (2dea0ca)

Summary

✅ 29 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 8, 2024

Merge activity

  • Aug 8, 11:24 AM EDT: rzvxa added this pull request to the Graphite merge queue.
  • Aug 8, 11:29 AM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Aug 8, 11:33 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Aug 8, 11:35 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 8, 11:36 AM EDT: The merge label 'merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Aug 8, 11:42 AM EDT: The merge label 'merge' was removed. This PR will no longer be merged by the Graphite merge queue

@rzvxa rzvxa changed the base branch from 08-08-refactor_ast_codegen_consistent_import_order to graphite-base/4762 August 8, 2024 15:24
@rzvxa rzvxa changed the base branch from graphite-base/4762 to main August 8, 2024 15:28
@rzvxa rzvxa added the 0-merge Merge with Graphite Merge Queue label Aug 8, 2024 — with Graphite App
@rzvxa rzvxa force-pushed the 08-08-refactor_ast_codegen_consistent_endl_position branch from e3ac900 to 4b152f4 Compare August 8, 2024 15:33
Pure refactor (style nit). Place `endl!()` macro calls in consistent position throughout codegen.
@rzvxa rzvxa force-pushed the 08-08-refactor_ast_codegen_consistent_endl_position branch from 4b152f4 to 80046d1 Compare August 8, 2024 15:39
@graphite-app graphite-app bot merged commit 80046d1 into main Aug 8, 2024
@graphite-app graphite-app bot deleted the 08-08-refactor_ast_codegen_consistent_endl_position branch August 8, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants