Skip to content

Comments

refactor(ast_codegen): consistent import order#4761

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-08-refactor_ast_codegen_consistent_import_order
Aug 8, 2024
Merged

refactor(ast_codegen): consistent import order#4761
graphite-app[bot] merged 1 commit intomainfrom
08-08-refactor_ast_codegen_consistent_import_order

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 8, 2024

Pure refactor. Alter import order in generated code to consistent order - std, external crates, crate, super.

@github-actions github-actions bot added the A-ast Area - AST label Aug 8, 2024
Copy link
Member Author

overlookmotel commented Aug 8, 2024

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 8, 2024

CodSpeed Performance Report

Merging #4761 will not alter performance

Comparing 08-08-refactor_ast_codegen_consistent_import_order (2dea0ca) with main (41f861f)

Summary

✅ 29 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 8, 2024

Merge activity

Pure refactor. Alter import order in generated code to consistent order - `std`, external crates, `crate`, `super`.
@rzvxa rzvxa force-pushed the 08-08-refactor_ast_codegen_consistent_import_order branch from 75857c0 to 2dea0ca Compare August 8, 2024 15:24
@graphite-app graphite-app bot merged commit 2dea0ca into main Aug 8, 2024
@graphite-app graphite-app bot deleted the 08-08-refactor_ast_codegen_consistent_import_order branch August 8, 2024 15:27
@oxc-bot oxc-bot mentioned this pull request Aug 10, 2024
Boshen added a commit that referenced this pull request Aug 10, 2024
## [0.24.1] - 2024-08-10

### Features

- b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac)
- c519295 minifier: Add `InjectGlobalVariables` plugin
(`@rollup/plugin-inject`) (#4759) (Boshen)

### Bug Fixes

- fff9da3 ast, ast_codegen: Use `generate_derive` instead of visitable
for generating span derives. (#4747) (rzvxa)
- f5eeebd ast_macros: Raise compile error on invalid `generate_derive`
input. (#4766) (rzvxa)
- 4d0b40a napi/transform: Fix wrong isolated declarations emit (Boshen)

### Refactor

- daa0b2e ast: `oxc_ast` crate re-export AST types from other crates
(#4773) (overlookmotel)
- d4a3be8 ast_codegen: Line breaks between types in layout assertions
(#4781) (overlookmotel)
- dbb5f4c ast_codegen: Remove unnecessary imports from generated files
(#4774) (overlookmotel)
- 7ea058d ast_codegen: Replace Windows-style line breaks with Unix-style
(#4769) (overlookmotel)
- 2dea0ca ast_codegen: Consistent import order (#4761) (overlookmotel)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant