feat(oxlint): implement --print-config cli option#4742
feat(oxlint): implement --print-config cli option#4742nicksrandall wants to merge 11 commits intooxc-project:mainfrom
--print-config cli option#4742Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This looks related to #4720. I'd like to reach consensus there before we merge this. |
|
The cli can get merged first because it's a eslint command. Behavior wise I think it should just print out whatever is read, it doesn't matter whether it's v8 or v9. |
|
If ESLint supports it then we should too. |
|
@nicksrandall it appears CI checks are not passing, let me know when you're ready for a review. |
|
@DonIsaac I believe I'm ready for review. Thanks you! |
CodSpeed Performance ReportMerging #4742 will not alter performanceComparing Summary
|
|
I'm not sure why the tests are failing... there must be some issue when a struct implements "Serialize" and "JsonSchema" traits? Any idea on how I can fix ? |
|
Tests are failing because there are schema snapshots that need updating. Have you run |
| let mut config = serde_json::to_value(self.eslint_config.as_ref()).unwrap(); | ||
| config | ||
| .get_mut("rules") | ||
| .unwrap() |
There was a problem hiding this comment.
Please use expect and provide an error message, otherwise users will have no idea what happened.
|
|
||
|
|
||
| ## settings | ||
|
|
|
Hi! @nicksrandall Do you mind me taking this? |
|
Please do! |
|
Close in favor of #6579 |
4 participants
I've attempted to implement
--print-configfor oxlint. This implementation works but I'm almost certain there is a better way to do this and I'm open to feedback.See discussion: #4279