• refactor(ast_codegen): declutter the main file. #4741
• chore(ci): generate .generated_ast_watch_list.yml #4737 👈
• refactor(ast, ast_codegen): use generate_derive for implementing GetSpan and GetSpanMut traits. #4735
• refactor(ast): use type identifier instead of CloneIn::Cloned GAT. #4738
• feat(ast): derive CloneIn for AST types, using generate_derive. #4732
• feat(ast_codegen): add derive_clone_in generator. #4731
• feat(ast_codegen): support for generate_derive marker. #4728
• feat(syntax): derive CloneIn for the AST-related items. #4730
• feat(span): implement CloneIn for the AST-related items. #4729
• feat(allocator): introduce CloneIn trait. #4726
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

CodSpeed Performance Report

Merging #4737 will not alter performance

_{Comparing 08-07-chore_ci_generate_.generated_ast_watch_list.yml_ (aeed29f) with main (2218340)}

Summary

✅ 29 untouched benchmarks

Not reviewed in full yet, but a couple of quick things:

1. Is there a reason for . on start of .generated_ast_watch_list.yml? Can it be just generated_ast_watch_list.yml?
2. Could you add a line break on end of the file?

1. Is there a reason for `.` on start of `.generated_ast_watch_list.yml`? Can it be just `generated_ast_watch_list.yml`?

It is a preference thing, Since the file is generated and we wish to forget about it; Having it hidden might be better.
Now that we always keep the CI filter updated there is no need to worry about this file. Think of it like a socket file or named pipe, It is just an identifier to pass data to our CI on behalf of the codegen.

2. Could you add a line break on end of the file?

Sure, I don't like the trailing newline but that's just me.

Merge activity

• Aug 7, 6:08 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 7, 6:09 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
• Aug 7, 6:18 PM EDT: overlookmotel merged this pull request with the Graphite merge queue.

1. Is there a reason for . on start of .generated_ast_watch_list.yml? Can it be just generated_ast_watch_list.yml?

It is a preference thing, Since the file is generated and we wish to forget about it; Having it hidden might be better. Now that we always keep the CI filter updated there is no need to worry about this file. Think of it like a socket file or named pipe, It is just an identifier to pass data to our CI on behalf of the codegen.

OK cool.

2. Could you add a line break on end of the file?

Sure, I don't like the trailing newline but that's just me.

It's a matter of taste, but it's the project's convention...