Skip to content

Comments

feat(linter): add fix emoji to rules table and doc pages#4715

Merged
graphite-app[bot] merged 1 commit intomainfrom
don/08-06-feat_linter_add_fix_emoji_to_rules_table
Aug 10, 2024
Merged

feat(linter): add fix emoji to rules table and doc pages#4715
graphite-app[bot] merged 1 commit intomainfrom
don/08-06-feat_linter_add_fix_emoji_to_rules_table

Conversation

@DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Aug 6, 2024

Rules table:
image

Doc pages:
image

Copy link
Contributor Author

DonIsaac commented Aug 6, 2024

@DonIsaac DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from be1445a to d787b05 Compare August 6, 2024 22:47
@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 6db8202 to df146ec Compare August 6, 2024 22:47
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 6, 2024

CodSpeed Performance Report

Merging #4715 will not alter performance

Comparing don/08-06-feat_linter_add_fix_emoji_to_rules_table (3d40528) with main (a266b45)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from d787b05 to 957bea4 Compare August 9, 2024 20:00
@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from df146ec to 6f8a2ef Compare August 9, 2024 20:00
@Boshen Boshen force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from 957bea4 to 5028db4 Compare August 10, 2024 00:17
@Boshen Boshen force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 6f8a2ef to 20f427a Compare August 10, 2024 00:18
@DonIsaac DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from 5028db4 to 71f1b60 Compare August 10, 2024 02:04
@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 20f427a to bbb9185 Compare August 10, 2024 02:05
@DonIsaac DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from 71f1b60 to 68b4468 Compare August 10, 2024 03:42
@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from bbb9185 to 18850eb Compare August 10, 2024 03:42
@DonIsaac DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from 68b4468 to c49cc99 Compare August 10, 2024 03:43
@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 18850eb to cc8c12f Compare August 10, 2024 03:43
@DonIsaac DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from 22f1f4e to 2afa0cf Compare August 10, 2024 04:56
@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from cc8c12f to 4763b57 Compare August 10, 2024 04:56
@DonIsaac DonIsaac force-pushed the don/08-04-test_linter_ensure_rule_docs_are_valid_markdown branch from 2afa0cf to 5d6d035 Compare August 10, 2024 05:00
@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 4763b57 to e47b77c Compare August 10, 2024 05:00
@DonIsaac DonIsaac changed the base branch from don/08-04-test_linter_ensure_rule_docs_are_valid_markdown to graphite-base/4715 August 10, 2024 05:03
@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from e47b77c to fd82f6e Compare August 10, 2024 05:07
@DonIsaac DonIsaac force-pushed the graphite-base/4715 branch from 5d6d035 to 8f2a566 Compare August 10, 2024 05:07
@DonIsaac DonIsaac changed the base branch from graphite-base/4715 to main August 10, 2024 05:08
@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from fd82f6e to b8d5f76 Compare August 10, 2024 16:36
@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from b8d5f76 to 3f77f18 Compare August 10, 2024 19:04
@DonIsaac DonIsaac added the C-enhancement Category - New feature or request label Aug 10, 2024
@DonIsaac DonIsaac marked this pull request as ready for review August 10, 2024 19:40
@DonIsaac DonIsaac requested review from camc314 and mysteryven August 10, 2024 19:40
@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 3f77f18 to eb2691e Compare August 10, 2024 20:18
@DonIsaac DonIsaac changed the title feat(linter): add fix emoji to rules table feat(linter): add fix emoji to rules table and doc pages Aug 10, 2024
@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from eb2691e to 4b77659 Compare August 10, 2024 20:52
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice stuff!

@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Aug 10, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 10, 2024

Merge activity

  • Aug 10, 6:48 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 10, 6:51 PM EDT: DonIsaac added this pull request to the Graphite merge queue.
  • Aug 10, 6:54 PM EDT: DonIsaac merged this pull request with the Graphite merge queue.

@DonIsaac DonIsaac force-pushed the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch from 8334871 to 3d40528 Compare August 10, 2024 22:50
@graphite-app graphite-app bot merged commit 3d40528 into main Aug 10, 2024
@graphite-app graphite-app bot deleted the don/08-06-feat_linter_add_fix_emoji_to_rules_table branch August 10, 2024 22:54
@oxc-bot oxc-bot mentioned this pull request Aug 12, 2024
Boshen added a commit that referenced this pull request Aug 12, 2024
## [0.7.1] - 2024-08-12

### Features

- 3d40528 linter: Add fix emoji to rules table and doc pages (#4715)
(DonIsaac)
- d2734f3 linter: Start fixer for no-unused-vars (#4718) (DonIsaac)
- 070ae53 linter: Add fixer for unicorn prefer-string-replace-all
(#4801) (camc314)
- b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac)
- 5992b75 linter: Implement `eslint-plugin-promise/no-return-in-finally,
prefer-await-to-then` rule (#4318) (Jelle van der Waa)
- b259f47 linter: Add fixer for unicorn/no-length-as-slice-end (#4780)
(heygsc)
- abd83fa linter: Add fixer for jsx_ally/no_aria_hidden_on_focusable
(#4772) (heygsc)
- b20e335 linter: Add fixer for eslint/no-eq-null (#4758) (heygsc)
- 2f6c3b9 linter: Add fixer for eslint/no-compare-neg-zero (#4748)
(heygsc)
- eaddc8f linter: Add fixer for eslint/func_names (#4714) (DonIsaac)
- 80557a9 linter: Add fixer for eslint/for-direction (#4679) (heygsc)
- c3c5766 linter/eslint-plugin-promise: Implement valid-params (#4598)
(Jelle van der Waa)
- c509a21 linter/eslint-plugin-vitest: Implement prefer-to-be-falsy
(#4770) (dalaoshu)
- 41f861f linter/eslint-plugin-vitest: Implement prefer-to-be-truthy
(#4755) (dalaoshu)
- cc922f4 vscode: Provide config's schema to oxlint config files (#4826)
(Don Isaac)
- f629514 website: Auto-generate rule docs pages (#4640) (DonIsaac)

### Bug Fixes

- b22ed45 linter: Improve prefer_namespace_keyword rule (#4751) (Burlin)
- db68a6c linter: Fixer for eslint/for-direction (#4727) (heygsc)
- 6273994 linter: Block in eslint/no_cond_assign (#4721) (heygsc)
- b9d6aa5 linter: Fix false positives in no-confusing-non-null-assertion
(#4665) (Renée)
- cbf08d2 linter: Skip no-multi-str on jsx attributes (#4666) (heygsc)
- a6f9f96 linter: No unused errors should be warnings (Boshen)
- 7345bc9 linter/func-names: Handle ts accessibility when reporting
missing names (#4713) (DonIsaac)

### Performance

- d191823 linter: Optmize allocations in jest fn parsing (#4787) (lucab)
- e3abdfa linter: Reduce String allocations and clones (#4673)
(DonIsaac)

### Documentation

- 4b7dfd6 linter: Correct docs for no-unused-vars (#4716) (Don Isaac)

### Refactor

- 096ac7b linter: Clean up jsx-a11y/anchor-is-valid (#4831) (DonIsaac)
- 15a0fd4 linter: Use Option to reduce nested level in
`eslint/getter-return` (#4814) (IWANABETHATGUY)
- 63f274c linter: Simplify NoObjCalls resolution logic (#4765) (lucab)
- 6708680 linter: Replace Windows-style line breaks with Unix-style in
test fixture (#4768) (overlookmotel)
- e285903 linter: Clean up eslint/func_names (#4710) (DonIsaac)

### Testing

- 8f2a566 linter: Ensure rule docs have valid syntax (#4644) (DonIsaac)
- 4dd29db linter: Add fixer test for unicorn/no-zero-fractions (#4783)
(heygsc)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants