Skip to content

Comments

chore(module_lexer): Fix invalid regex in test#4683

Merged
Boshen merged 1 commit intomainfrom
fix/regex-in-tests
Aug 6, 2024
Merged

chore(module_lexer): Fix invalid regex in test#4683
Boshen merged 1 commit intomainfrom
fix/regex-in-tests

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Aug 6, 2024

To make the #4242 tests pass.

(My RegExp parser tells me /as)df/ is invalid syntax. 😂)

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 6, 2024

CodSpeed Performance Report

Merging #4683 will not alter performance

Comparing fix/regex-in-tests (cd07e35) with main (6133761)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen merged commit bc611d7 into main Aug 6, 2024
@Boshen Boshen deleted the fix/regex-in-tests branch August 6, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants