refactor(ast_codegen): move away from RType in generators.#4682
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 6, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
CodSpeed Performance ReportMerging #4682 will not alter performanceComparing Summary
|
rzvxa
force-pushed
the
08-06-refactor_ast_codegen_move_away_from_rtype_in_generators
branch
from
009c234 to
b51e7b0
Compare
rzvxa
changed the base branch from
main
to
08-06-refactor_ast_add_explicit_enum_discriminants
This was referenced Aug 6, 2024
rzvxa
force-pushed
the
08-06-refactor_ast_codegen_move_away_from_rtype_in_generators
branch
from
b691815 to
1350541
Compare
rzvxa
changed the base branch from
08-06-refactor_ast_add_explicit_enum_discriminants
to
08-06-refactor_syntax_add_explicit_enum_discriminants_to_ast_related_types
This was referenced Aug 6, 2024
rzvxa
force-pushed
the
08-06-refactor_syntax_add_explicit_enum_discriminants_to_ast_related_types
branch
from
1d1315e to
a2621cd
Compare
rzvxa
force-pushed
the
08-06-refactor_ast_codegen_move_away_from_rtype_in_generators
branch
from
1350541 to
05d5cd6
Compare
overlookmotel
approved these changes
Aug 6, 2024
overlookmotel
force-pushed
the
08-06-refactor_syntax_add_explicit_enum_discriminants_to_ast_related_types
branch
from
a2621cd to
e24fb5b
Compare
Contributor
Merge activity
|
overlookmotel
changed the base branch from
08-06-refactor_syntax_add_explicit_enum_discriminants_to_ast_related_types
to
main
This PR introduces `EarlyCtx` and `LateCtx` in place of the old `CodegenCtx`, Early passes operate at the AST level while generators and other late passes operate on the schema. It will also replace the confusing `RType` name with something more idiomatic ~~(open for suggestions, I haven't found a good name yet)~~ I've named it `AstType` and dropped the `R` prefix for `REnum` and `RStruct`. There are some qualities of life improvements too, Things like `to_type_elide` can be used to simplify the code. Related to #4442 (and can potentially mark it "close as fixed").
overlookmotel
force-pushed
the
08-06-refactor_ast_codegen_move_away_from_rtype_in_generators
branch
from
05d5cd6 to
1690a57
Compare
graphite-app
bot
deleted the
08-06-refactor_ast_codegen_move_away_from_rtype_in_generators
branch
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
EarlyCtxandLateCtxin place of the oldCodegenCtx, Early passes operate at the AST level while generators and other late passes operate on the schema.It will also replace the confusing
RTypename with something more idiomatic(open for suggestions, I haven't found a good name yet)I've named itAstTypeand dropped theRprefix forREnumandRStruct.There are some qualities of life improvements too, Things like
to_type_elidecan be used to simplify the code.Related to #4442 (and can potentially mark it "close as fixed").