test(linter): ensure rule docs have valid syntax#4644
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 10, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #4644 will not alter performanceComparing Summary
|
DonIsaac
force-pushed
the
don/08-04-feat_website_auto-generate_rule_docs_pages
branch
from
4c3c1d2 to
118821e
Compare
DonIsaac
force-pushed
the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
from
7c41199 to
654ee5e
Compare
DonIsaac
force-pushed
the
don/08-04-feat_website_auto-generate_rule_docs_pages
branch
from
118821e to
90fe51f
Compare
DonIsaac
force-pushed
the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
from
654ee5e to
3d74cce
Compare
DonIsaac
force-pushed
the
don/08-04-feat_website_auto-generate_rule_docs_pages
branch
from
90fe51f to
a4131cc
Compare
DonIsaac
force-pushed
the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
2 times, most recently
from
c19042d to
376954f
Compare
DonIsaac
changed the title
DonIsaac
force-pushed
the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
2 times, most recently
from
d55dab0 to
6803de2
Compare
DonIsaac
force-pushed
the
don/08-04-feat_website_auto-generate_rule_docs_pages
branch
from
a4131cc to
ab59cff
Compare
DonIsaac
force-pushed
the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
from
6803de2 to
be1445a
Compare
DonIsaac
commented
Aug 5, 2024
DonIsaac
commented
Aug 5, 2024
DonIsaac
force-pushed
the
don/08-04-feat_website_auto-generate_rule_docs_pages
branch
from
ab59cff to
c34beee
Compare
DonIsaac
force-pushed
the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
from
be1445a to
d787b05
Compare
DonIsaac
force-pushed
the
don/08-04-feat_website_auto-generate_rule_docs_pages
branch
from
c34beee to
2fe39dd
Compare
DonIsaac
force-pushed
the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
from
d787b05 to
957bea4
Compare
Boshen
changed the base branch from
don/08-04-feat_website_auto-generate_rule_docs_pages
to
graphite-base/4644
Boshen
force-pushed
the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
from
957bea4 to
5028db4
Compare
Boshen
force-pushed
the
graphite-base/4644
branch
from
2fe39dd to
f629514
Compare
DonIsaac
force-pushed
the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
3 times, most recently
from
68b4468 to
c49cc99
Compare
mysteryven
approved these changes
Aug 10, 2024
DonIsaac
force-pushed
the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
from
22f1f4e to
2afa0cf
Compare
Contributor
Merge activity
|
DonIsaac
force-pushed
the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
from
2afa0cf to
5d6d035
Compare
Adds tests for rule documentation by 1. Compiling doc markdown into HTML, which ensures docs use valid markdown syntax 2. Converts the generated HTML into JSX and parses the results with the parser, ensuring the generated HTML is valid Has the added benefit of adding a lot of JSX test cases to the parser. I've also fixed all violations for these tests in this PR.
DonIsaac
force-pushed
the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
from
5d6d035 to
8f2a566
Compare
graphite-app
bot
deleted the
don/08-04-test_linter_ensure_rule_docs_are_valid_markdown
branch
Merged
Boshen
added a commit
that referenced
this pull request
Aug 12, 2024
## [0.7.1] - 2024-08-12 ### Features - 3d40528 linter: Add fix emoji to rules table and doc pages (#4715) (DonIsaac) - d2734f3 linter: Start fixer for no-unused-vars (#4718) (DonIsaac) - 070ae53 linter: Add fixer for unicorn prefer-string-replace-all (#4801) (camc314) - b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac) - 5992b75 linter: Implement `eslint-plugin-promise/no-return-in-finally, prefer-await-to-then` rule (#4318) (Jelle van der Waa) - b259f47 linter: Add fixer for unicorn/no-length-as-slice-end (#4780) (heygsc) - abd83fa linter: Add fixer for jsx_ally/no_aria_hidden_on_focusable (#4772) (heygsc) - b20e335 linter: Add fixer for eslint/no-eq-null (#4758) (heygsc) - 2f6c3b9 linter: Add fixer for eslint/no-compare-neg-zero (#4748) (heygsc) - eaddc8f linter: Add fixer for eslint/func_names (#4714) (DonIsaac) - 80557a9 linter: Add fixer for eslint/for-direction (#4679) (heygsc) - c3c5766 linter/eslint-plugin-promise: Implement valid-params (#4598) (Jelle van der Waa) - c509a21 linter/eslint-plugin-vitest: Implement prefer-to-be-falsy (#4770) (dalaoshu) - 41f861f linter/eslint-plugin-vitest: Implement prefer-to-be-truthy (#4755) (dalaoshu) - cc922f4 vscode: Provide config's schema to oxlint config files (#4826) (Don Isaac) - f629514 website: Auto-generate rule docs pages (#4640) (DonIsaac) ### Bug Fixes - b22ed45 linter: Improve prefer_namespace_keyword rule (#4751) (Burlin) - db68a6c linter: Fixer for eslint/for-direction (#4727) (heygsc) - 6273994 linter: Block in eslint/no_cond_assign (#4721) (heygsc) - b9d6aa5 linter: Fix false positives in no-confusing-non-null-assertion (#4665) (Renée) - cbf08d2 linter: Skip no-multi-str on jsx attributes (#4666) (heygsc) - a6f9f96 linter: No unused errors should be warnings (Boshen) - 7345bc9 linter/func-names: Handle ts accessibility when reporting missing names (#4713) (DonIsaac) ### Performance - d191823 linter: Optmize allocations in jest fn parsing (#4787) (lucab) - e3abdfa linter: Reduce String allocations and clones (#4673) (DonIsaac) ### Documentation - 4b7dfd6 linter: Correct docs for no-unused-vars (#4716) (Don Isaac) ### Refactor - 096ac7b linter: Clean up jsx-a11y/anchor-is-valid (#4831) (DonIsaac) - 15a0fd4 linter: Use Option to reduce nested level in `eslint/getter-return` (#4814) (IWANABETHATGUY) - 63f274c linter: Simplify NoObjCalls resolution logic (#4765) (lucab) - 6708680 linter: Replace Windows-style line breaks with Unix-style in test fixture (#4768) (overlookmotel) - e285903 linter: Clean up eslint/func_names (#4710) (DonIsaac) ### Testing - 8f2a566 linter: Ensure rule docs have valid syntax (#4644) (DonIsaac) - 4dd29db linter: Add fixer test for unicorn/no-zero-fractions (#4783) (heygsc) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for rule documentation by
Has the added benefit of adding a lot of JSX test cases to the parser. I've also fixed all violations for these tests in this PR.