Skip to content

Comments

refactor(sourcemap): remove unnecessary reserves#4635

Closed
overlookmotel wants to merge 1 commit into08-04-perf_sourcemap_concatsourcemapbuilder_extend_source_contents_in_separate_loopfrom
08-05-refactor_sourcemap_remove_unnecessary_reserve_s
Closed

refactor(sourcemap): remove unnecessary reserves#4635
overlookmotel wants to merge 1 commit into08-04-perf_sourcemap_concatsourcemapbuilder_extend_source_contents_in_separate_loopfrom
08-05-refactor_sourcemap_remove_unnecessary_reserve_s

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 4, 2024 •
edited
Loading

Vec::reserve before Vec::extend is unnecessary where extending from a "trusted" iterator which accurately reports its length. Rust already reserves required space in these cases.

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Aug 4, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel mentioned this pull request Aug 4, 2024
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 4, 2024

CodSpeed Performance Report

Merging #4635 will not alter performance

Comparing 08-05-refactor_sourcemap_remove_unnecessary_reserve_s (3be8660) with 08-04-perf_sourcemap_concatsourcemapbuilder_extend_source_contents_in_separate_loop (0198b30)

Summary

✅ 32 untouched benchmarks

This was referenced Aug 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@overlookmotel