refactor(ast_codegen): abstract passes and generators behind Runner trait.#4556
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 2, 2024
Conversation
This was referenced Jul 30, 2024
Contributor
Author
CodSpeed Performance ReportMerging #4556 will not alter performanceComparing Summary
|
a5c36b2 to
38ab21d
Compare
10d992e to
e822ba6
Compare
This was referenced Jul 30, 2024
38ab21d to
9aa6953
Compare
e822ba6 to
425f59c
Compare
9aa6953 to
c08d405
Compare
425f59c to
c4345a1
Compare
Contributor
Author
|
@overlookmotel These 3 are also ready to be reviewed. The last PR is also for review, But not ready to be merged. |
overlookmotel
approved these changes
Aug 1, 2024
Member
overlookmotel
left a comment
There was a problem hiding this comment.
To be honest, I'm not on top of everything codegen is doing / how it's working, so hard for me to review in full. But if you're happy with this, please go ahead and merge.
c08d405 to
0151aff
Compare
c4345a1 to
7106360
Compare
Contributor
Merge activity
|
0151aff to
abc8836
Compare
7106360 to
f39e759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.