fix(benchmark): sourcemap benchmark properly test ConcatSourceMapBuilder#4528
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
|
I'm pretty sure (2) was a mistake, but I don't know for sure what this benchmark is aiming to measure. Can anyone confirm? |
CodSpeed Performance ReportMerging #4528 will degrade performances by 28.58%Comparing Summary
Benchmarks breakdown
|
Merge activity
|
…lder` (#4528) Make 2 changes to sourcemap benchmark: 1. Move counting line breaks in output text to outside of the measured loop. This operation is reasonably expensive, and isn't part of what we're trying to measure. 2. It looks like benchmark is trying to measure concatenating 2 source maps, but `for i in 0..1` was actually only concatenating 1.
Brooooooklyn
force-pushed
the
07-29-fix_benchmark_sourcemap_benchmark_properly_test_concatsourcemapbuilder_
branch
from
436ad02 to
affd768
Compare
graphite-app
bot
deleted the
07-29-fix_benchmark_sourcemap_benchmark_properly_test_concatsourcemapbuilder_
branch
2 participants
Make 2 changes to sourcemap benchmark:
Move counting line breaks in output text to outside of the measured loop. This operation is reasonably expensive, and isn't part of what we're trying to measure.
It looks like benchmark is trying to measure concatenating 2 source maps, but
for i in 0..1was actually only concatenating 1.