Skip to content

Comments

ci: run benchmarks on rust-toolchain.toml changes#4479

Merged
overlookmotel merged 1 commit intomainfrom
07-26-ci_run_benchmarks_on_rust-toolchain.toml_changes
Jul 26, 2024
Merged

ci: run benchmarks on rust-toolchain.toml changes#4479
overlookmotel merged 1 commit intomainfrom
07-26-ci_run_benchmarks_on_rust-toolchain.toml_changes

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 26, 2024

Upgrading to Rust 1.80.0 (#4474) regressed some benchmarks (#4478). We didn't notice because benchmarks didn't run on the PR. Make benchmarks run on changes to rust-toolchain.toml so we'll be alerted if this happens again on any future updates.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@overlookmotel overlookmotel marked this pull request as ready for review July 26, 2024 10:25
@overlookmotel overlookmotel requested a review from Boshen July 26, 2024 10:28
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 26, 2024

CodSpeed Performance Report

Merging #4479 will degrade performances by 12.93%

Comparing 07-26-ci_run_benchmarks_on_rust-toolchain.toml_changes (6200a38) with main (ccb1835)

Summary

❌ 3 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 07-26-ci_run_benchmarks_on_rust-toolchain.toml_changes Change
prepass[antd.js] 15.8 ms 17.6 ms -10.17%
prepass[react.development.js] 207.4 µs 232.9 µs -10.95%
prepass[typescript.js] 27.9 ms 32.1 ms -12.93%

@overlookmotel overlookmotel merged commit 42a2519 into main Jul 26, 2024
@overlookmotel overlookmotel deleted the 07-26-ci_run_benchmarks_on_rust-toolchain.toml_changes branch July 26, 2024 10:33
@overlookmotel
Copy link
Member Author

Have merged this so that CodSpeed has the current benchmarks for main branch, so we can accurately measure perf impact of other PRs (e.g. #4476).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant