Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

• test(coverage): add Test262 semantic tests #4454 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

CodSpeed Performance Report

Merging #4454 will not alter performance

_{Comparing don/07-24-test_coverage_add_test262_semantic_tests (69ab79d) with main (b58ed80)}

Summary

✅ 32 untouched benchmarks

We copied a lot of tests from typescrip-eslint for testing scope/symbols in #3990. do we need this anymore?

Despite #3990, I do still think testing scopes against Test262 too is probably a good idea, for 2 reasons:

1. I imagine Test262 probably covers more weird edge cases (e.g. some strange stuff in sloppy mode code).
2. chore(semantic): copy tests from typescript-eslint’s scope-manager #3990 ported the test cases, but doesn't actually check them against the typescript-eslint's snapshots (see Verify scope tree and symbols table match TypeScript #4316).

How far off were you from getting this working @DonIsaac?

@overlookmotel the test infra works, but the tests need review. Not sure how to continue. @Dunqing thoughts?

I agreed to continue this work. But It's not just test262. we also need to check that the semantics in the TypeScript is correct.

I'm going to work on this in #4790