chore: fix failed publish caused by cyclic dev dependencies #4416
Merged
Dunqing merged 3 commits intooxc-project:mainfrom Jul 23, 2024
Merged
chore: fix failed publish caused by cyclic dev dependencies #4416Dunqing merged 3 commits intooxc-project:mainfrom
Dunqing merged 3 commits intooxc-project:mainfrom
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
Member
|
Do we have a way to verify this is work |
Contributor
Author
|
I don't know, cc @Boshen |
Contributor
Author
|
Because the dev cyclic dependency still exists, you can't make sure if this works until you try to make a new release, AFAIK, this is probably the best workaround, since |
Dunqing
changed the title
Dunqing
changed the title
DonIsaac
pushed a commit
that referenced
this pull request
Jul 23, 2024
1. This looks like caused by rust-lang/cargo#4242 1. rust-lang/futures-rs#2305
DonIsaac
pushed a commit
that referenced
this pull request
Jul 24, 2024
1. This looks like caused by rust-lang/cargo#4242 1. rust-lang/futures-rs#2305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref