feat(linter): implement `eslint-plugin-promise/no-return-in-finally, prefer-await-to-then` rule by jelly · Pull Request #4318 · oxc-project/oxc

jelly · 2024-07-17T09:17:29Z

Part of #4252

graphite-app · 2024-07-17T09:17:35Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

codspeed-hq · 2024-07-17T09:24:40Z

CodSpeed Performance Report

Merging #4318 will not alter performance

_{Comparing jelly:eslint-plugin-promise-part-2 (a63ec37) with main (c519295)}

Summary

✅ 29 untouched benchmarks

jelly · 2024-07-17T09:29:10Z

CodSpeed Performance Report

Merging #4318 will degrade performances by 3.29%

Comparing jelly:eslint-plugin-promise-part-2 (3d385b6) with main (5d17675)

Summary

❌ 2 regressions ✅ 30 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jelly:eslint-plugin-promise-part-2 Change
❌ linter[cal.com.tsx] 776.4 ms 801.8 ms -3.17%
❌ linter[checker.ts] 1.4 s 1.5 s -3.29%

So I assume this is due to a new rule being slow?

crates/oxc_linter/src/rules/promise/valid_params.rs

crates/oxc_linter/src/rules/promise/no_return_in_finally.rs

crates/oxc_linter/src/utils/promise.rs

Boshen · 2024-07-30T10:46:36Z

@mysteryven Would you like to help and land this?

jelly · 2024-07-30T11:22:27Z

@mysteryven Would you like to help and land this?

I intend to handle the review comments I got, but first I want to land #4109 (comment)

jelly · 2024-08-01T17:19:32Z

@mysteryven Would you like to help and land this?

I intend to handle the review comments I got, but first I want to land #4109 (comment)

Worked on this today a bit, split up the easiest rule into a separate PR as that had very few comments. Applied the two comments in this PR there.

#4598

Rule detail: [link](https://github.com/eslint-community/eslint-plugin-promise/blob/main/docs/rules/no-return-in-finally.md)

Rule detail: [link](https://github.com/eslint-community/eslint-plugin-promise/blob/main/docs/rules/prefer-await-to-then.md)

mysteryven

Hi, jelly, thank you, we want to merge your PR!

no_return_in_finally.rs mark as nursery now, but feel free to continue working on it any time you like. We are really appreciate your work and contributions all the time!

## [0.7.1] - 2024-08-12 ### Features - 3d40528 linter: Add fix emoji to rules table and doc pages (#4715) (DonIsaac) - d2734f3 linter: Start fixer for no-unused-vars (#4718) (DonIsaac) - 070ae53 linter: Add fixer for unicorn prefer-string-replace-all (#4801) (camc314) - b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac) - 5992b75 linter: Implement `eslint-plugin-promise/no-return-in-finally, prefer-await-to-then` rule (#4318) (Jelle van der Waa) - b259f47 linter: Add fixer for unicorn/no-length-as-slice-end (#4780) (heygsc) - abd83fa linter: Add fixer for jsx_ally/no_aria_hidden_on_focusable (#4772) (heygsc) - b20e335 linter: Add fixer for eslint/no-eq-null (#4758) (heygsc) - 2f6c3b9 linter: Add fixer for eslint/no-compare-neg-zero (#4748) (heygsc) - eaddc8f linter: Add fixer for eslint/func_names (#4714) (DonIsaac) - 80557a9 linter: Add fixer for eslint/for-direction (#4679) (heygsc) - c3c5766 linter/eslint-plugin-promise: Implement valid-params (#4598) (Jelle van der Waa) - c509a21 linter/eslint-plugin-vitest: Implement prefer-to-be-falsy (#4770) (dalaoshu) - 41f861f linter/eslint-plugin-vitest: Implement prefer-to-be-truthy (#4755) (dalaoshu) - cc922f4 vscode: Provide config's schema to oxlint config files (#4826) (Don Isaac) - f629514 website: Auto-generate rule docs pages (#4640) (DonIsaac) ### Bug Fixes - b22ed45 linter: Improve prefer_namespace_keyword rule (#4751) (Burlin) - db68a6c linter: Fixer for eslint/for-direction (#4727) (heygsc) - 6273994 linter: Block in eslint/no_cond_assign (#4721) (heygsc) - b9d6aa5 linter: Fix false positives in no-confusing-non-null-assertion (#4665) (Renée) - cbf08d2 linter: Skip no-multi-str on jsx attributes (#4666) (heygsc) - a6f9f96 linter: No unused errors should be warnings (Boshen) - 7345bc9 linter/func-names: Handle ts accessibility when reporting missing names (#4713) (DonIsaac) ### Performance - d191823 linter: Optmize allocations in jest fn parsing (#4787) (lucab) - e3abdfa linter: Reduce String allocations and clones (#4673) (DonIsaac) ### Documentation - 4b7dfd6 linter: Correct docs for no-unused-vars (#4716) (Don Isaac) ### Refactor - 096ac7b linter: Clean up jsx-a11y/anchor-is-valid (#4831) (DonIsaac) - 15a0fd4 linter: Use Option to reduce nested level in `eslint/getter-return` (#4814) (IWANABETHATGUY) - 63f274c linter: Simplify NoObjCalls resolution logic (#4765) (lucab) - 6708680 linter: Replace Windows-style line breaks with Unix-style in test fixture (#4768) (overlookmotel) - e285903 linter: Clean up eslint/func_names (#4710) (DonIsaac) ### Testing - 8f2a566 linter: Ensure rule docs have valid syntax (#4644) (DonIsaac) - 4dd29db linter: Add fixer test for unicorn/no-zero-fractions (#4783) (heygsc) Co-authored-by: Boshen <[email protected]>

github-actions bot added the A-linter Area - Linter label Jul 17, 2024

jelly commented Jul 17, 2024

View reviewed changes

crates/oxc_linter/src/rules/promise/valid_params.rs Outdated Show resolved Hide resolved

jelly commented Jul 17, 2024

View reviewed changes

crates/oxc_linter/src/rules/promise/no_return_in_finally.rs Show resolved Hide resolved

jelly commented Jul 17, 2024

View reviewed changes

crates/oxc_linter/src/rules/promise/no_return_in_finally.rs Show resolved Hide resolved

DonIsaac requested review from DonIsaac and mysteryven July 17, 2024 15:06

DonIsaac added the C-enhancement Category - New feature or request label Jul 17, 2024

DonIsaac reviewed Jul 17, 2024

View reviewed changes

jelly mentioned this pull request Aug 1, 2024

feat(linter/eslint-plugin-promise): implement valid-params #4598

Merged

jelly force-pushed the eslint-plugin-promise-part-2 branch 2 times, most recently from b63b4c4 to 3956fe1 Compare August 1, 2024 17:54

feat(linter/eslint-plugin-promise): implement no-return-in-finally

f3d94b0

Rule detail: [link](https://github.com/eslint-community/eslint-plugin-promise/blob/main/docs/rules/no-return-in-finally.md)

jelly force-pushed the eslint-plugin-promise-part-2 branch from f2eb608 to a72bc75 Compare August 9, 2024 16:17

feat(linter/eslint-plugin-promise): implement prefer-await-to-then

c36d36e

Rule detail: [link](https://github.com/eslint-community/eslint-plugin-promise/blob/main/docs/rules/prefer-await-to-then.md)

jelly force-pushed the eslint-plugin-promise-part-2 branch from a72bc75 to c36d36e Compare August 9, 2024 16:20

mysteryven added 2 commits August 10, 2024 10:01

Merge branch 'main' into eslint-plugin-promise-part-2

7c730de

chore: update

a63ec37

mysteryven approved these changes Aug 10, 2024

View reviewed changes

mysteryven changed the title ~~Eslint plugin promise part 2~~ feat(linter): implement eslint-plugin-promise/no-return-in-finally, prefer-await-to-then rule Aug 10, 2024

mysteryven changed the title ~~feat(linter): implement eslint-plugin-promise/no-return-in-finally, prefer-await-to-then rule~~ feat(linter): implement eslint-plugin-promise/no-return-in-finally, prefer-await-to-then rule Aug 10, 2024

mysteryven merged commit 5992b75 into oxc-project:main Aug 10, 2024

oxc-bot mentioned this pull request Aug 12, 2024

Release oxlint v0.7.1 #4835

Merged

jelly deleted the eslint-plugin-promise-part-2 branch August 14, 2024 14:26

Uh oh!

Comments

Conversation

jelly commented Jul 17, 2024

Uh oh!

graphite-app bot commented Jul 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

codspeed-hq bot commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #4318 will not alter performance

Summary

Uh oh!

jelly commented Jul 17, 2024

CodSpeed Performance Report

Merging #4318 will degrade performances by 3.29%

Summary

Benchmarks breakdown

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Boshen commented Jul 30, 2024

Uh oh!

jelly commented Jul 30, 2024

Uh oh!

jelly commented Aug 1, 2024

Uh oh!

mysteryven left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codspeed-hq bot commented Jul 17, 2024 •

edited

Loading