refactor(semantic): directly record `current_node_id` when adding a scope by Dunqing · Pull Request #4265 · oxc-project/oxc

Dunqing · 2024-07-15T02:50:36Z

graphite-app · 2024-07-15T02:50:40Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Dunqing · 2024-07-15T02:50:50Z

refactor(semantic): directly record current_node_id when adding a scope #4265 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

graphite-app · 2024-07-15T02:59:04Z

Merge activity

Jul 14, 10:59 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jul 14, 11:06 PM EDT: Boshen merged this pull request with the Graphite merge queue.

…cope (#4265) close: #4234

codspeed-hq · 2024-07-15T03:30:33Z

CodSpeed Performance Report

Merging #4265 will not alter performance

_{Comparing 07-15-refactor_semantic_directly_record_current_node_id_when_adding_a_scope (c418bf5) with main (c418bf5)}

Summary

✅ 32 untouched benchmarks

lucab · 2024-07-15T07:22:05Z

crates/oxc_semantic/src/builder.rs

    pub fn build(mut self, program: &Program<'a>) -> SemanticBuilderReturn<'a> {
        if self.source_type.is_typescript_definition() {
-            let scope_id = self.scope.add_scope(None, ScopeFlags::Top);
+            let scope_id = self.scope.add_scope(None, AstNodeId::dummy(), ScopeFlags::Top);


Why not self.current_node_id here?

Good question. I guess we could do that.

Please feel free to submit a PR.

We don't build semantic for .d.ts file now. So we haven't current_node_id. We may need to build semantic for d.ts in the future. Rolldown needs this to bundle types to one entry point.

lucab · 2024-07-15T07:23:25Z

crates/oxc_traverse/src/context/scoping.rs

    pub fn create_scope_child_of_current(&mut self, flags: ScopeFlags) -> ScopeId {
        let flags = self.scopes.get_new_scope_flags(flags, self.current_scope_id);
-        self.scopes.add_scope(Some(self.current_scope_id), flags)
+        self.scopes.add_scope(Some(self.current_scope_id), AstNodeId::dummy(), flags)


I think this will result in multiple scopes having the same node ID (0), is this a bug in the logic?

I can answer this one. Traverse is a mutating visitor. For this reason, it does not use all of Semantic. It can't use AstNodes because that contains AstKinds which contain references to all actual AST nodes. Holding that would be a violation of Rust's aliasing rules, because visitor functions also get passed &mut references to AST nodes => would result in having a live & and &mut reference to same AST node simultaneously.

So... long story short... Traverse uses only an incomplete subset of Semantic and that doesn't include AstNodes, so it uses dummy AstNodeIds.

This is part of what I hope to look at when I review Semantic. We need some way to merge the 2 paradigms.

## [0.21.0] - 2024-07-18 - d7ab0b8 semantic: [**BREAKING**] Simplify node creation (#4226) (lucab) ### Features - af4dc01 ast: Align ts ast scope with typescript (#4253) (Dunqing) - 83c2c62 codegen: Add option for choosing quotes; remove slow `choose_quot` method (#4219) (Boshen) - 5d17675 mangler: Add debug mode (#4314) (Boshen) - e3e663b mangler: Initialize crate and integrate into minifier (#4197) (Boshen) - c818472 minifier: Dce conditional expression `&&` or `||` (#4190) (Boshen) - 8a190eb oxc: Export `oxc_mangler` (Boshen) - 20cdb1f semantic: Align class scope with typescript (#4195) (Dunqing) - 92ee774 semantic: Add `ScopeFlags::CatchClause` for use in CatchClause (#4205) (Dunqing) - 205c259 sourcemap: Support SourceMapBuilder#token_chunks (#4220) (underfin) - 7eb960d transformer: Decode xml character entity `&#xhhhh` and `&#nnnn;` (#4235) (Boshen) ### Bug Fixes - bf3d8d3 codegen: Print annotation comment inside parens for new and call expressions (#4290) (Boshen) - 084ab76 codegen: Use `ryu-js` for f64 to string (Boshen) - e167ef7 codegen: Print parenthesis properly (#4245) (Boshen) - c65198f codegen: Choose the right quote for jsx attribute string (#4236) (Boshen) - be82c28 codegen: Print `JSXAttributeValue::StringLiteral` directly (#4231) (Boshen) - 3df9e69 mangler: No shorthand `BindingProperty`; handle var hoisting and export variables (#4319) (Boshen) - f144082 minifier: RemoveDeadCode should visit nested expression (#4268) (underfin) - 66b455a oxc_codegen: Avoid print same pure comments multiple time (#4230) (IWANABETHATGUY) - 9a87e41 parser: Avoid crashing on invalid const modifier (#4267) (lucab) - 641a78b parser: Fix tests for number parsing (#4254) (overlookmotel) - 9badac0 semantic: Avoid var hosting insert the var variable to the `CatchClause` scope (#4337) (Dunqing) - 95e15b6 semantic: Incorrect resolve references for `ExportSpecifier` (#4320) (Dunqing) - c362bf7 semantic: Incorrect resolve references for `TSInterfaceHeritage` (#4311) (Dunqing) - 351ecf2 semantic: Incorrect resolve references for `TSTypeQuery` (#4310) (Dunqing) - 1108f2a semantic: Resolve references to the incorrect symbol (#4280) (Dunqing) - 22d56bd semantic: Do not resolve references after `FormalParameters` in TS type (#4241) (overlookmotel)- 1c117eb Avoid print extra semicolon after accessor property (#4199) (IWANABETHATGUY) ### Performance - a8dc4f3 parser: Speed up parsing numbers with `_` separators (#4259) (overlookmotel) - b94540d parser: Speed up parsing octal literals (#4258) (overlookmotel) - a7b328c parser: Faster parsing decimal numbers (#4257) (overlookmotel) - f9d3f2e semantic: Inline ast record functions (#4272) (overlookmotel) - 8fad7db semantic: Reduce `AstNodeId` to `u32` (#4264) (overlookmotel) - 23743db semantic: Do not record ast nodes for cfg if cfg disabled (#4263) (overlookmotel) - da69076 semantic: Reduce overhead of cfg recording ast nodes (#4262) (overlookmotel) - cb15303 semantic: Reduce memory copies (#4216) (overlookmotel) - ef4c1f4 semantic: Reduce lookups (#4214) (overlookmotel) - f23e54f semantic: Recycle unresolved references hash maps (#4213) (overlookmotel) - 2602ce2 semantic: Reuse existing map of unresolved refs (#4206) (lucab) ### Refactor - 2c7bb9f ast: Pass final `ScopeFlags` into `visit_function` (#4283) (overlookmotel) - 3e099fe ast: Move `enter_scope` after `visit_binding_identifier` (#4246) (Dunqing) - aab7aaa ast/visit: Fire node events as the outermost one. (#4203) (rzvxa) - d1c4be0 codegen: Clean up annotation_comment (Boshen) - 06197b8 codegen: Separate tests (Boshen) - aa22073 codegen: Improve print API (#4196) (Boshen) - c5731a5 semantic: Remove defunct code setting ScopeFlags twice (#4286) (overlookmotel) - 16698bc semantic: Move function/class-specific code into specific visitors (#4278) (overlookmotel) - ee16668 semantic: Rename function param (#4277) (overlookmotel) - 25f0771 semantic: Alter syntax of `control_flow!` macro (#4275) (overlookmotel) - 639fd48 semantic: Comment why extra CFG enabled check (#4274) (overlookmotel) - c418bf5 semantic: Directly record `current_node_id` when adding a scope (#4265) (Dunqing) - ace4f1f semantic: Update the order of `visit_function` and `Visit` fields in the builder to be consistent (#4248) (Dunqing) - 8bfeabf semantic: Simplify adding `SymbolFlags::Export` (#4249) (Dunqing) - dc2b3c4 semantic: Add strict mode in scope flags for class definitions (#4156) (Dunqing) - 81ed588 semantic: Convert scope fields to IndexVecs (#4208) (lucab) - bbe5ded semantic: Set `current_scope_id` to `scope_id` in `enter_scope` (#4193) (Dunqing) - 7f1addd semantic: Correct scope in CatchClause (#4192) (Dunqing) - fc0b17d syntax: Turn the `AstNodeId::dummy` into a constant field. (#4308) (rzvxa) - a197e01 transformer/typescript: Remove unnecessary code (#4321) (Dunqing) - 1458d81 visit: Add `#[inline]` to empty functions (#4330) (overlookmotel) Co-authored-by: Boshen <[email protected]>

github-actions bot added the A-semantic Area - Semantic label Jul 15, 2024

Dunqing changed the title ~~refactor(semantic): directly record current_node_id when adding a scope~~ refactor(semantic): directly record current_node_id when adding a scope Jul 15, 2024

Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 15, 2024

refactor(semantic): directly record current_node_id when adding a s…

c418bf5

…cope (#4265) close: #4234

Boshen force-pushed the 07-15-refactor_semantic_directly_record_current_node_id_when_adding_a_scope branch from 856cfb3 to c418bf5 Compare July 15, 2024 03:02

graphite-app bot merged commit c418bf5 into main Jul 15, 2024

graphite-app bot deleted the 07-15-refactor_semantic_directly_record_current_node_id_when_adding_a_scope branch July 15, 2024 03:06

lucab reviewed Jul 15, 2024

View reviewed changes

This was referenced Jul 17, 2024

Release crates v0.21.0 #4325

Closed

Release crates v0.21.0 #4338

Merged

github-actions bot mentioned this pull request Jul 18, 2024

Release crates v0.21.0 #4344

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

refactor(semantic): directly record `current_node_id` when adding a scope#4265

refactor(semantic): directly record `current_node_id` when adding a scope#4265
graphite-app[bot] merged 1 commit intomainfrom
07-15-refactor_semantic_directly_record_current_node_id_when_adding_a_scope

Dunqing commented Jul 15, 2024

Uh oh!

graphite-app bot commented Jul 15, 2024

Uh oh!

Dunqing commented Jul 15, 2024

Uh oh!

graphite-app bot commented Jul 15, 2024 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jul 15, 2024

Uh oh!

lucab Jul 15, 2024

Uh oh!

overlookmotel Jul 15, 2024

Uh oh!

overlookmotel Jul 15, 2024

Uh oh!

Dunqing Jul 15, 2024

Uh oh!

lucab Jul 15, 2024

Uh oh!

overlookmotel Jul 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Comments

Conversation

Dunqing commented Jul 15, 2024

Uh oh!

graphite-app bot commented Jul 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

Dunqing commented Jul 15, 2024

Uh oh!

graphite-app bot commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

codspeed-hq bot commented Jul 15, 2024

CodSpeed Performance Report

Merging #4265 will not alter performance

Summary

Uh oh!

lucab Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

overlookmotel Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

overlookmotel Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

Dunqing Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

lucab Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

overlookmotel Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

graphite-app bot commented Jul 15, 2024 •

edited

Loading