Skip to content

Comments

perf(semantic): avoid repeated hashing resolving bindings#4238

Closed
overlookmotel wants to merge 15 commits intomainfrom
07-12-perf_semantic_avoid_repeated_hashing_resolving_bindings
Closed

perf(semantic): avoid repeated hashing resolving bindings#4238
overlookmotel wants to merge 15 commits intomainfrom
07-12-perf_semantic_avoid_repeated_hashing_resolving_bindings

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 12, 2024 •
edited
Loading

WIP. Just an experiment really at this stage.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-semantic Area - Semantic label Jul 12, 2024
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Jul 12, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4238 will not alter performance

Comparing 07-12-perf_semantic_avoid_repeated_hashing_resolving_bindings (480090c) with main (ab41c52)

Summary

✅ 32 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 07-12-perf_semantic_avoid_repeated_hashing_resolving_bindings branch from 681b7f6 to 0620d75 Compare July 12, 2024 19:01
@github-actions github-actions bot added the A-linter Area - Linter label Jul 12, 2024
@overlookmotel overlookmotel force-pushed the 07-12-perf_semantic_avoid_repeated_hashing_resolving_bindings branch from 67268c4 to b1b4b96 Compare July 13, 2024 02:09
@overlookmotel overlookmotel changed the base branch from main to 07-13-fix_semantic_do_not_resolve_references_after_formalparameters_in_ts_type July 13, 2024 02:09
@overlookmotel overlookmotel mentioned this pull request Jul 13, 2024
Merged
@overlookmotel overlookmotel requested review from Dunqing and removed request for Dunqing July 13, 2024 02:10
@Boshen Boshen force-pushed the 07-13-fix_semantic_do_not_resolve_references_after_formalparameters_in_ts_type branch from 531bf11 to 22d56bd Compare July 13, 2024 02:43
@Boshen Boshen changed the base branch from 07-13-fix_semantic_do_not_resolve_references_after_formalparameters_in_ts_type to main July 13, 2024 02:47
@Boshen Boshen force-pushed the 07-12-perf_semantic_avoid_repeated_hashing_resolving_bindings branch from b1b4b96 to 9775674 Compare July 13, 2024 02:47
@overlookmotel overlookmotel force-pushed the 07-12-perf_semantic_avoid_repeated_hashing_resolving_bindings branch from 9775674 to 463b7d1 Compare July 13, 2024 20:52
@overlookmotel overlookmotel force-pushed the 07-12-perf_semantic_avoid_repeated_hashing_resolving_bindings branch from 44c6662 to 406d97e Compare July 13, 2024 21:31
@overlookmotel
Copy link
Member Author

overlookmotel commented Jul 13, 2024 •
edited
Loading

@Boshen This is my attempt at oxc-project/backlog#83. It stores hashes and so avoids rehashing on every insert, but the benchmark result is meh. Disappointing!

I've tried tweaking it in a bunch of ways, but nothing seems to make much difference.

Do you think worth tidying it up and merging? Or leave it for now and see if storing hash in Atom and using that everywhere has more of an effect?

@Boshen
Copy link
Member

Boshen commented Jul 14, 2024

Let's close. This'll make future changes harder.

@Boshen Boshen closed this Jul 14, 2024
@Boshen Boshen deleted the 07-12-perf_semantic_avoid_repeated_hashing_resolving_bindings branch August 12, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing will be requested when the pull request is marked ready for review Dunqing is a code owner

@camc314 camc314 Awaiting requested review from camc314 camc314 will be requested when the pull request is marked ready for review camc314 is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

A-linter Area - Linter A-semantic Area - Semantic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @Boshen