Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #4151 will degrade performances by 98.34%Comparing Summary
Benchmarks breakdown
|
…y' of github.com:oxc-project/oxc into don/07-09-feat_linter_better_schemas_for_allow/warn/deny
…ithub.com:oxc-project/oxc into don/07-09-feat_linter_strongly-typed_rule_schemas
DonIsaac
force-pushed
the
don/07-09-feat_linter_better_schemas_for_allow/warn/deny
branch
from
0387c40 to
cc58614
Compare
DonIsaac
changed the base branch from
don/07-09-feat_linter_better_schemas_for_allow/warn/deny
to
main
|
Just a small performance regression 😆 I'll fix that |
There was a problem hiding this comment.
This is huge and seems pointless to snapshot anymore because every rule change will change this file 😅 We can read the json and test its content instead.
There was a problem hiding this comment.
Same reason. We need to stop committing this file and generate on demand instead.
|
Concerning the perf regression, I think it's just that this branch is out of date with main. I think you'll find if you rebase on latest main, it'll disappear. |
|
@overlookmotel I've entered rebase purgatory on this branch, I'll create a new one and re-open this PR. |
|
Re-created in #4174 |
Boshen
deleted the
don/07-09-feat_linter_strongly-typed_rule_schemas
branch
3 participants
Part of #4146
feat(linter): strongly-typed rule schemas
feat(macros): schema parsing for declare_oxc_lint macro
Screenshots