refactor(semantic): should not add symbols of ClassExpression and FunctionExpression to the scope#4141
Closed
Closed
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
Dunqing
force-pushed
the
07-10-refactor_semantic_should_not_add_symbols_of_classexpression_and_functionexpression_to_the_scope
branch
from
e5721da to
adfebfa
Compare
CodSpeed Performance ReportMerging #4141 will degrade performances by 3.12%Comparing Summary
Benchmarks breakdown
|
Dunqing
force-pushed
the
07-10-refactor_semantic_should_not_add_symbols_of_classexpression_and_functionexpression_to_the_scope
branch
from
adfebfa to
9920171
Compare
Dunqing
changed the base branch from
main
to
07-10-refactor_semantic_add_strict_mode_in_scope_flags_for_class_definitions
This was referenced Jul 10, 2024
Dunqing
force-pushed
the
07-10-refactor_semantic_add_strict_mode_in_scope_flags_for_class_definitions
branch
from
f676841 to
e88e957
Compare
Dunqing
force-pushed
the
07-10-refactor_semantic_should_not_add_symbols_of_classexpression_and_functionexpression_to_the_scope
branch
5 times, most recently
from
a4e1a1a to
357ad9f
Compare
Dunqing
changed the base branch from
07-10-refactor_semantic_add_strict_mode_in_scope_flags_for_class_definitions
to
07-11-refactor_semantic_set_current_scope_id_to_scope_id_in_enter_scope
This was referenced Jul 11, 2024
Dunqing
force-pushed
the
07-10-refactor_semantic_should_not_add_symbols_of_classexpression_and_functionexpression_to_the_scope
branch
from
357ad9f to
cbb7bfd
Compare
Dunqing
changed the base branch from
07-11-refactor_semantic_set_current_scope_id_to_scope_id_in_enter_scope
to
07-11-feat_semantic_align_class_scope_with_typescript
Dunqing
force-pushed
the
07-11-feat_semantic_align_class_scope_with_typescript
branch
from
f5a2d06 to
2634b62
Compare
Dunqing
force-pushed
the
07-10-refactor_semantic_should_not_add_symbols_of_classexpression_and_functionexpression_to_the_scope
branch
from
cbb7bfd to
520d1f1
Compare
Dunqing
force-pushed
the
07-11-feat_semantic_align_class_scope_with_typescript
branch
from
2634b62 to
7fe477a
Compare
Dunqing
force-pushed
the
07-11-feat_semantic_align_class_scope_with_typescript
branch
from
7fe477a to
3f07793
Compare
Boshen
deleted the
07-10-refactor_semantic_should_not_add_symbols_of_classexpression_and_functionexpression_to_the_scope
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript Behavior
Create a symbol for the
idofClassExpressionandFunctionExpressionbut doesn't add to the scopeClassExpression: https://github.com/microsoft/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/binder.ts#L3598-L3605FunctionExpression: https://github.com/microsoft/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/binder.ts#L3714-L3726Different resolve logic is implemented specifically for these ASTs.
ClassExpression: https://github.com/microsoft/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/utilities.ts#L11310-L11316FunctionExpression: https://github.com/microsoft/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/utilities.ts#L11375-L11378