Skip to content

Comments

feat(ast): allow conversion from Expression into Statement with FromIn trait.#4124

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait
Jul 9, 2024
Merged

feat(ast): allow conversion from Expression into Statement with FromIn trait.#4124
graphite-app[bot] merged 1 commit intomainfrom
07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait

Conversation

@rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jul 8, 2024 •
edited
Loading

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-ast Area - AST label Jul 8, 2024
This was referenced Jul 8, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@rzvxa Graphite App
Copy link
Contributor Author

rzvxa commented Jul 8, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4124 will not alter performance

Comparing 07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait (485c871) with main (e29cdbf)

Summary

✅ 29 untouched benchmarks

@rzvxa rzvxa marked this pull request as ready for review July 8, 2024 19:27
@rzvxa rzvxa changed the title feat(ast): allow conversion between ExpressionStatement and Statement with FromIn trait. feat(ast): allow conversion from Expression into Statement with FromIn trait. Jul 8, 2024
@rzvxa rzvxa force-pushed the 07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names branch from 1a82128 to 451cf2e Compare July 8, 2024 22:28
@rzvxa rzvxa force-pushed the 07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait branch from bf33017 to 05f1f4d Compare July 8, 2024 22:29
overlookmotel
overlookmotel reviewed Jul 9, 2024
View reviewed changes
@rzvxa rzvxa force-pushed the 07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait branch 2 times, most recently from 0634b50 to d91c6a1 Compare July 9, 2024 00:25
@overlookmotel overlookmotel force-pushed the 07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names branch from 05e145b to e69c323 Compare July 9, 2024 00:55
@overlookmotel overlookmotel force-pushed the 07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait branch from d91c6a1 to aec2e90 Compare July 9, 2024 00:55
@overlookmotel overlookmotel force-pushed the 07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names branch from e69c323 to 2943085 Compare July 9, 2024 01:10
@overlookmotel overlookmotel force-pushed the 07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait branch from aec2e90 to 195c762 Compare July 9, 2024 01:10
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 9, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 9, 2024 •
edited
Loading

Merge activity

  • Jul 8, 11:40 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 8, 11:40 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 8, 11:55 PM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #4122.
  • Jul 8, 11:55 PM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #4122.
  • Jul 9, 8:13 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 9, 8:16 AM EDT: rzvxa added this pull request to the Graphite merge queue.
  • Jul 9, 8:22 AM EDT: rzvxa merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names branch from 2943085 to 69cea86 Compare July 9, 2024 03:44
Boshen pushed a commit that referenced this pull request Jul 9, 2024
@rzvxa
feat(ast): allow conversion from Expression into Statement with `…
3536aaf 
…FromIn` trait. (#4124)

Our downstream rolldown is using this, If we want them to adopt our traits we should provide this implementation for them.

https://github.com/rolldown/rolldown/blob/2cd2a367ee25c3d1f711fda9b1d3ead5982cfcff/crates/rolldown_ecmascript/src/allocator_helpers/into_in.rs#L24
@Boshen Boshen force-pushed the 07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait branch from 195c762 to 3536aaf Compare July 9, 2024 03:44
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 9, 2024
@rzvxa rzvxa force-pushed the 07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names branch from 69cea86 to c5a6e9e Compare July 9, 2024 12:12
rzvxa added a commit that referenced this pull request Jul 9, 2024
@rzvxa
feat(ast): allow conversion from Expression into Statement with `…
a859564 
…FromIn` trait. (#4124)

Our downstream rolldown is using this, If we want them to adopt our traits we should provide this implementation for them.

https://github.com/rolldown/rolldown/blob/2cd2a367ee25c3d1f711fda9b1d3ead5982cfcff/crates/rolldown_ecmascript/src/allocator_helpers/into_in.rs#L24
@rzvxa rzvxa force-pushed the 07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait branch from 3536aaf to a859564 Compare July 9, 2024 12:12
@rzvxa rzvxa added the 0-merge Merge with Graphite Merge Queue label Jul 9, 2024
@rzvxa rzvxa force-pushed the 07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names branch from c5a6e9e to b936162 Compare July 9, 2024 12:16
@rzvxa rzvxa force-pushed the 07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait branch from a859564 to 485c871 Compare July 9, 2024 12:17
@rzvxa rzvxa changed the base branch from 07-08-refactor_ast_ast_builder_shorter_allocator_utility_method_names to main July 9, 2024 12:20
@graphite-app graphite-app bot merged commit 485c871 into main Jul 9, 2024
@graphite-app graphite-app bot deleted the 07-08-feat_ast_allow_conversion_between_expressionstatement_and_statement_with_fromin_trait branch July 9, 2024 12:22
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
Merged
Boshen added a commit that referenced this pull request Jul 9, 2024
@github-actions @Boshen
Release crates v0.19.0 (#4137)
714bf1d 
## [0.19.0] - 2024-07-09

- b936162 ast/ast_builder: [**BREAKING**] Shorter allocator utility
method names. (#4122) (rzvxa)

### Features

- 485c871 ast: Allow conversion from `Expression` into `Statement` with
`FromIn` trait. (#4124) (rzvxa)

### Refactor

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rzvxa @overlookmotel @Boshen