Skip to content

Comments

feat(oxc_codegen): generate annotation comments before CallExpression and NewExpression#4119

Merged
IWANABETHATGUY merged 1 commit intooxc-project:mainfrom
IWANABETHATGUY:feat/annotation-comments
Jul 8, 2024
Merged

feat(oxc_codegen): generate annotation comments before CallExpression and NewExpression#4119
IWANABETHATGUY merged 1 commit intooxc-project:mainfrom
IWANABETHATGUY:feat/annotation-comments

Conversation

@IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Jul 8, 2024

  1. test case copy from vue/core, here are all usages of #__PURE__ in vue/core https://gist.github.com/IWANABETHATGUY/c7911ecd98467a2969b2a994a34d32bc#file-pure_annotation_in_vue_repo-sh
  2. Also took a look in other codebase, https://github.com/search?q=%23__PURE__&type=code, most of the usage of #__PURE__ attached as leading comment before CallExpression and NewExpression

@IWANABETHATGUY IWANABETHATGUY requested a review from Boshen July 8, 2024 15:49
@github-actions github-actions bot added the A-codegen Area - Code Generation label Jul 8, 2024
@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/annotation-comments branch from 1a1aa53 to 4566099 Compare July 8, 2024 15:55
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 8, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 8, 2024

Merge activity

  • Jul 8, 12:05 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 8, 12:05 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 8, 12:06 PM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).
  • Jul 8, 12:08 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 8, 12:10 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 8, 12:11 PM EDT: Boshen added this pull request to the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 8, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 8, 2024 — with Graphite App
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 8, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 8, 2024

CodSpeed Performance Report

Merging #4119 will not alter performance

Comparing IWANABETHATGUY:feat/annotation-comments (4566099) with main (44c7fe3)

Summary

✅ 29 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY merged commit 365d9ba into oxc-project:main Jul 8, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the feat/annotation-comments branch July 9, 2024 01:45
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
Boshen added a commit that referenced this pull request Jul 9, 2024
## [0.18.0] - 2024-07-09

- d347aed ast: [**BREAKING**] Generate `ast_builder.rs`. (#3890) (rzvxa)

### Features

- c6c16a5 minifier: Dce all conditional expressions (#4135) (Boshen)
- 365d9ba oxc_codegen: Generate annotation comments before
`CallExpression` and `NewExpression` (#4119) (IWANABETHATGUY)
- 3a0f2aa parser: Check for illegal modifiers in modules and namespaces
(#4126) (DonIsaac)
- 2f53bdf semantic: Check for abstract ClassElements in non-abstract
classes (#4127) (DonIsaac)
- c4ee9f8 semantic: Check for abstract initializations and
implementations (#4125) (Don Isaac)
- 44c7fe3 span: Add various implementations of `FromIn` for `Atom`.
(#4090) (rzvxa)

### Bug Fixes

- cb1af04 isolated-declarations: Remove the `async` and `generator`
keywords from `MethodDefinition` (#4130) (Dunqing)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants