Skip to content

Comments

fix(transformer): missing initializer for readonly consructor properties#4103

Merged
Dunqing merged 1 commit intomainfrom
don/transformer/fix/readonly-missing-initializer
Jul 8, 2024
Merged

fix(transformer): missing initializer for readonly consructor properties#4103
Dunqing merged 1 commit intomainfrom
don/transformer/fix/readonly-missing-initializer

Conversation

@DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jul 8, 2024

Closes #4032

@DonIsaac DonIsaac added C-bug Category - Bug A-transformer Area - Transformer / Transpiler labels Jul 8, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 8, 2024

CodSpeed Performance Report

Merging #4103 will not alter performance

Comparing don/transformer/fix/readonly-missing-initializer (a1edce6) with main (e386b62)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac requested a review from Dunqing July 8, 2024 04:43
@Dunqing Dunqing merged commit 4413e2d into main Jul 8, 2024
@Dunqing Dunqing deleted the don/transformer/fix/readonly-missing-initializer branch July 8, 2024 04:45
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Boshen added a commit that referenced this pull request Jul 8, 2024
## [0.17.2] - 2024-07-08

### Features

- 115ac3b allocator: Introduce `FromIn` and `IntoIn` traits. (#4088)
(rzvxa)
- 720983a napi/transform: Allow setting `sourceType` to `transform`
(#4113) (Boshen)
- e386b62 semantic: Check for invalid type import assignments (#4097)
(DonIsaac)

### Bug Fixes

- 5472b7c codegen: 256 indentations level is not enough for codegen
(Boshen)
- 5c31236 isolated-declarations: Keep literal value for readonly
property (#4106) (Dunqing)
- e67c7d1 isolated-declarations: Do not infer type for private
parameters (#4105) (Dunqing)
- 3fcad5e isolated_declarations: Remove nested AssignmentPatterns from
inside parameters (#4077) (michaelm)
- f8d77e4 isolated_declarations: Infer type of template literal
expressions as string (#4068) (michaelm)
- 0f02608 semantic: Bind `TSImportEqualsDeclaration`s (#4100) (Don
Isaac)
- 4413e2d transformer: Missing initializer for readonly consructor
properties (#4103) (Don Isaac)

### Performance

- 7ed27b7 isolated-declarations: Use `FxHashSet` instead of `Vec` to
speed up the `contain` (#4074) (Dunqing)
- 9114c8e semantic: Keep a single map of unresolved references (#4107)
(Luca Bruno)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transformer: missing initializer for TypeScript class constructor when argument is readonly

2 participants