fix(isolated_declarations): Remove nested AssignmentPatterns from inside parameters#4077
Merged
Dunqing merged 1 commit intooxc-project:mainfrom Jul 8, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4077 will not alter performanceComparing Summary
|
Dunqing
requested changes
Jul 7, 2024
MichaelMitchell-at
force-pushed
the
07-07-fix_isolated_declarations_remove_nested_assignmentpatterns_from_inside_parameters
branch
from
d3b8a7f to
a0899b5
Compare
MichaelMitchell-at
force-pushed
the
07-07-fix_isolated_declarations_remove_nested_assignmentpatterns_from_inside_parameters
branch
from
a0899b5 to
69e052c
Compare
MichaelMitchell-at
force-pushed
the
07-07-fix_isolated_declarations_remove_nested_assignmentpatterns_from_inside_parameters
branch
from
69e052c to
c77db8e
Compare
MichaelMitchell-at
deleted the
07-07-fix_isolated_declarations_remove_nested_assignmentpatterns_from_inside_parameters
branch
Merged
Boshen
added a commit
that referenced
this pull request
Jul 8, 2024
## [0.17.2] - 2024-07-08 ### Features - 115ac3b allocator: Introduce `FromIn` and `IntoIn` traits. (#4088) (rzvxa) - 720983a napi/transform: Allow setting `sourceType` to `transform` (#4113) (Boshen) - e386b62 semantic: Check for invalid type import assignments (#4097) (DonIsaac) ### Bug Fixes - 5472b7c codegen: 256 indentations level is not enough for codegen (Boshen) - 5c31236 isolated-declarations: Keep literal value for readonly property (#4106) (Dunqing) - e67c7d1 isolated-declarations: Do not infer type for private parameters (#4105) (Dunqing) - 3fcad5e isolated_declarations: Remove nested AssignmentPatterns from inside parameters (#4077) (michaelm) - f8d77e4 isolated_declarations: Infer type of template literal expressions as string (#4068) (michaelm) - 0f02608 semantic: Bind `TSImportEqualsDeclaration`s (#4100) (Don Isaac) - 4413e2d transformer: Missing initializer for readonly consructor properties (#4103) (Don Isaac) ### Performance - 7ed27b7 isolated-declarations: Use `FxHashSet` instead of `Vec` to speed up the `contain` (#4074) (Dunqing) - 9114c8e semantic: Keep a single map of unresolved references (#4107) (Luca Bruno) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default values in destructured parameters are retained in declarations, which can cause captured variables to be part of the emit when they shouldn't be. This can also lead to unnecessary isolated declaration errors when those variables are themselves missing type annotations and can't be inferred.
For example:
before this change will be emitted as:
and after this change will be emitted as: