Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
changed the title
FxHashSet instead of Vec to speed up the contain
CodSpeed Performance ReportMerging #4074 will improve performances by ×5.2Comparing Summary
Benchmarks breakdown
|
Boshen
requested changes
Jul 7, 2024
Member
Boshen
left a comment
Boshen
left a comment
There was a problem hiding this comment.
We need a benchmark at this point, can you add a large one to https://github.com/oxc-project/benchmark-files, generate a benchmark on main, and then rebase this PR so we observe the difference?
Dunqing
force-pushed
the
07-07-perf_isolated-declarations_use_fxhashset_instead_of_vec_to_speed_up_the_contain
branch
from
bcc7fc3 to
6cd4b21
Compare
Dunqing
changed the base branch from
main
to
07-07-chore_benchmark_add_isolated_declarations
Dunqing
force-pushed
the
07-07-chore_benchmark_add_isolated_declarations
branch
from
57ab43b to
1a9e82c
Compare
Dunqing
force-pushed
the
07-07-perf_isolated-declarations_use_fxhashset_instead_of_vec_to_speed_up_the_contain
branch
from
6cd4b21 to
11c56cd
Compare
Base automatically changed from
07-07-chore_benchmark_add_isolated_declarations
to
main
July 7, 2024 09:14
Boshen
force-pushed
the
07-07-perf_isolated-declarations_use_fxhashset_instead_of_vec_to_speed_up_the_contain
branch
from
8e67380 to
ea493d6
Compare
Boshen
force-pushed
the
07-07-perf_isolated-declarations_use_fxhashset_instead_of_vec_to_speed_up_the_contain
branch
from
ea493d6 to
a5a2127
Compare
Member
Author
|
5.x faster than before 🤩 |
Boshen
approved these changes
Jul 7, 2024
Boshen
deleted the
07-07-perf_isolated-declarations_use_fxhashset_instead_of_vec_to_speed_up_the_contain
branch
Merged
Boshen
added a commit
that referenced
this pull request
Jul 8, 2024
## [0.17.2] - 2024-07-08 ### Features - 115ac3b allocator: Introduce `FromIn` and `IntoIn` traits. (#4088) (rzvxa) - 720983a napi/transform: Allow setting `sourceType` to `transform` (#4113) (Boshen) - e386b62 semantic: Check for invalid type import assignments (#4097) (DonIsaac) ### Bug Fixes - 5472b7c codegen: 256 indentations level is not enough for codegen (Boshen) - 5c31236 isolated-declarations: Keep literal value for readonly property (#4106) (Dunqing) - e67c7d1 isolated-declarations: Do not infer type for private parameters (#4105) (Dunqing) - 3fcad5e isolated_declarations: Remove nested AssignmentPatterns from inside parameters (#4077) (michaelm) - f8d77e4 isolated_declarations: Infer type of template literal expressions as string (#4068) (michaelm) - 0f02608 semantic: Bind `TSImportEqualsDeclaration`s (#4100) (Don Isaac) - 4413e2d transformer: Missing initializer for readonly consructor properties (#4103) (Don Isaac) ### Performance - 7ed27b7 isolated-declarations: Use `FxHashSet` instead of `Vec` to speed up the `contain` (#4074) (Dunqing) - 9114c8e semantic: Keep a single map of unresolved references (#4107) (Luca Bruno) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried it on my laptop. It was nearly three times faster than before.