fix(isolated_declarations): Infer type of template literal expressions as string#4068
Merged
Dunqing merged 1 commit intooxc-project:mainfrom Jul 7, 2024
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
MichaelMitchell-at
force-pushed
the
07-06-fix_isolated_declarations_infer_type_of_template_literal_expressions_as_string
branch
from
2b96215 to
d920382
Compare
CodSpeed Performance ReportMerging #4068 will not alter performanceComparing Summary
|
MichaelMitchell-at
force-pushed
the
07-06-fix_isolated_declarations_infer_type_of_template_literal_expressions_as_string
branch
2 times, most recently
from
bbe7a84 to
139ab90
Compare
Member
|
The oxc/crates/oxc_isolated_declarations/src/inferrer.rs Lines 28 to 34 in adee728 |
MichaelMitchell-at
force-pushed
the
07-06-fix_isolated_declarations_infer_type_of_template_literal_expressions_as_string
branch
from
139ab90 to
8e36a2b
Compare
Contributor
Author
|
@Dunqing I've updated the logic. Please have another look. |
MichaelMitchell-at
force-pushed
the
07-06-fix_isolated_declarations_infer_type_of_template_literal_expressions_as_string
branch
from
8e36a2b to
2c07709
Compare
MichaelMitchell-at
force-pushed
the
07-06-fix_isolated_declarations_infer_type_of_template_literal_expressions_as_string
branch
from
2c07709 to
4d52708
Compare
Dunqing
approved these changes
Jul 7, 2024
Merged
Boshen
added a commit
that referenced
this pull request
Jul 8, 2024
## [0.17.2] - 2024-07-08 ### Features - 115ac3b allocator: Introduce `FromIn` and `IntoIn` traits. (#4088) (rzvxa) - 720983a napi/transform: Allow setting `sourceType` to `transform` (#4113) (Boshen) - e386b62 semantic: Check for invalid type import assignments (#4097) (DonIsaac) ### Bug Fixes - 5472b7c codegen: 256 indentations level is not enough for codegen (Boshen) - 5c31236 isolated-declarations: Keep literal value for readonly property (#4106) (Dunqing) - e67c7d1 isolated-declarations: Do not infer type for private parameters (#4105) (Dunqing) - 3fcad5e isolated_declarations: Remove nested AssignmentPatterns from inside parameters (#4077) (michaelm) - f8d77e4 isolated_declarations: Infer type of template literal expressions as string (#4068) (michaelm) - 0f02608 semantic: Bind `TSImportEqualsDeclaration`s (#4100) (Don Isaac) - 4413e2d transformer: Missing initializer for readonly consructor properties (#4103) (Don Isaac) ### Performance - 7ed27b7 isolated-declarations: Use `FxHashSet` instead of `Vec` to speed up the `contain` (#4074) (Dunqing) - 9114c8e semantic: Keep a single map of unresolved references (#4107) (Luca Bruno) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a "non-
const" context, a template literal string can just be inferred astring. This is consistent with TypeScript's behavior.