fix(isolated_declarations): Don't report an error for parameters if they are ObjectPattern or ArrayPattern with an explicit type#4065
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4065 will not alter performanceComparing Summary
|
MichaelMitchell-at
force-pushed
the
07-06-fix_isolated_declarations_dont_report_an_error_for_parameters_if_they_are_objectpattern_or_arraypattern_with_an_explicit_type
branch
from
86fc701 to
536e744
Compare
…hey are ObjectPattern or ArrayPattern with an explicit type
MichaelMitchell-at
force-pushed
the
07-06-fix_isolated_declarations_dont_report_an_error_for_parameters_if_they_are_objectpattern_or_arraypattern_with_an_explicit_type
branch
from
536e744 to
3b6bb0e
Compare
Dunqing
approved these changes
Jul 6, 2024
Merged
Boshen
added a commit
that referenced
this pull request
Jul 6, 2024
## [0.17.1] - 2024-07-06 ### Bug Fixes - aa585d3 ast_codegen, ast: Visit `ExpressionArrayElement` as `Expression`. (#4061) (rzvxa) - 564a75a codegen: Missing TypeParameters in TSConstructSignature (#4063) (michaelm) - adee728 isolated_declarations: Don't report an error for parameters if they are ObjectPattern or ArrayPattern with an explicit type (#4065) (michaelm) - 1b8f208 isolated_declarations: Correct emit for private static methods (#4064) (michaelm) - 719fb96 minifier: Omit dce `undefined` which can be a shadowed variable (#4073) (Boshen) - 150f4d9 napi/transform: Display error with spanned messages (Boshen) ### Performance - 7fe2a2f parser: Do not copy comments (#4067) (overlookmotel) ### Refactor - 8fa98e0 ast: Inline trivial functions and shorten code (#4066) (overlookmotel) - 65aee19 isolated-declarations: Reorganize scope tree (#4070) (Luca Bruno) Co-authored-by: Boshen <[email protected]>
MichaelMitchell-at
deleted the
07-06-fix_isolated_declarations_dont_report_an_error_for_parameters_if_they_are_objectpattern_or_arraypattern_with_an_explicit_type
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic in #3810 was slightly off as demonstrated by the snapshot test.